From: Sylvain Lemieux <slemieux.tyco@gmail.com>
To: Guenter Roeck <linux@roeck-us.net>
Cc: linux-arm-kernel@lists.infradead.org, arnd@arndb.de,
wim@iguana.be, manabian@gmail.com,
linux-watchdog@vger.kernel.org, stigge@antcom.de, vz@mleia.com
Subject: Re: [PATCH v4 0/6] watchdog: pnx4008: add restart handler
Date: Fri, 26 Feb 2016 11:50:35 -0500 [thread overview]
Message-ID: <1456505435.28671.3.camel@localhost> (raw)
In-Reply-To: <56D07394.8030107@roeck-us.net>
On Fri, 2016-02-26 at 07:47 -0800, Guenter Roeck wrote:
> On 02/26/2016 07:34 AM, Sylvain Lemieux wrote:
> > On Fri, 2016-02-26 at 06:36 -0800, Guenter Roeck wrote:
> >> On 02/25/2016 10:31 AM, Sylvain Lemieux wrote:
> >>> From: Sylvain Lemieux <slemieux@tycoint.com>
> >>>
> >>> The LPC32xx provide the capability to perform a soft or hard reset;
> >>> a soft reset will no reset the external peripheral
> >>> (i.e. RESOUT_N output not asserted).
> >>>
> >>> This changeset migrate the restart code from the "mach-lpc32xx" to
> >>> the "pnx-4008" watchdog driver and add the soft reset capability.
> >>>
> >>> The default behavior (i.e. hard reset) remain unchanged.
> >>>
> >>> The core restart handler support added by this change:
> >>> 2165bf524da5f5e496d - "watchdog: core: add restart handler support"
> >>> is not use in this changeset; it does not support the reboot mode.
> >>
> >> I finally had the time to look into this. Sorry for the late reply.
> >>
> >> Changing the watchdog core to pass the restart mode (or action)
> >> and the cmd/data pointer to the driver would be trivial and should
> >> be done instead.
> >>
> > Thanks for the feedback.
> >
> > Do you want me to rebase this patchset on the patch you will submit
> > to update the core restart handler support?
> >
>
> Yes, please. I'll Cc: you on it.
>
> If you want to get started early and are open to do some early testing,
> try cloning git://kerneltests.org/git/linux.git. You'll find the patch
> in branch 'testing'.
>
Rebase and tested on a custom LPC32xx board.
> Thanks,
> Guenter
>
prev parent reply other threads:[~2016-02-26 16:50 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-02-25 18:31 [PATCH v4 0/6] watchdog: pnx4008: add restart handler Sylvain Lemieux
2016-02-25 18:31 ` [PATCH v4 1/6] watchdog: pnx4008: update logging during power-on Sylvain Lemieux
2016-02-26 14:15 ` Guenter Roeck
2016-02-25 18:31 ` [PATCH v4 2/6] watchdog: pnx4008: add restart handler Sylvain Lemieux
2016-02-25 18:31 ` [PATCH v4 3/6] watchdog: pnx4008: add support for soft reset Sylvain Lemieux
2016-02-25 18:31 ` [PATCH v4 4/6] watchdog: pnx4008: restart: support "cmd" from userspace Sylvain Lemieux
2016-02-25 18:31 ` [PATCH v4 5/6] arm: lpc32xx: phy3250 remove restart hook Sylvain Lemieux
2016-02-25 18:31 ` [PATCH v4 6/6] arm: lpc32xx: remove restart handler Sylvain Lemieux
2016-02-26 14:36 ` [PATCH v4 0/6] watchdog: pnx4008: add " Guenter Roeck
2016-02-26 15:34 ` Sylvain Lemieux
2016-02-26 15:47 ` Guenter Roeck
2016-02-26 16:50 ` Sylvain Lemieux [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1456505435.28671.3.camel@localhost \
--to=slemieux.tyco@gmail.com \
--cc=arnd@arndb.de \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-watchdog@vger.kernel.org \
--cc=linux@roeck-us.net \
--cc=manabian@gmail.com \
--cc=stigge@antcom.de \
--cc=vz@mleia.com \
--cc=wim@iguana.be \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).