From: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
To: Guenter Roeck <linux@roeck-us.net>,
Wim Van Sebroeck <wim@iguana.be>,
linux-watchdog@vger.kernel.org, mika.westerberg@linux.intel.com
Subject: Re: [PATCH v1 1/1] intel-mid_wdt: make sure watchdog is not running at startup
Date: Fri, 18 Nov 2016 19:36:42 +0200 [thread overview]
Message-ID: <1479490602.22212.33.camel@linux.intel.com> (raw)
In-Reply-To: <1a10bf0f-963c-c603-9e47-2e667191d3c8@roeck-us.net>
On Fri, 2016-11-18 at 07:50 -0800, Guenter Roeck wrote:
> On 11/18/2016 06:50 AM, Andy Shevchenko wrote:
> > Make sure that the watchdog is not running after loading
> > and before it is started by opening /dev/watchdog.
@@ -151,6 +151,9 @@ static int mid_wdt_probe(struct platform_device
> > + /* Make sure the watchdog is not running */
> > + wdt_stop(wdt_dev);
> > +
> > ret = watchdog_register_device(wdt_dev);
> This leaves the system exposed. Why not just tell the core if the
> watchdog
> is running and let it handle the ping until the device is opened ?
> Is it not possible to detect if the watchdog is running ?
It would be nice to have, but...
Just checked all documents I have access to. They even didn't describe a
content of watchdog IPC command!
So, we may just assume it's enabled by firmware until it is proven not
to.
--
Andy Shevchenko <andriy.shevchenko@linux.intel.com>
Intel Finland Oy
next prev parent reply other threads:[~2016-11-18 17:36 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-11-18 14:50 [PATCH v1 1/1] intel-mid_wdt: make sure watchdog is not running at startup Andy Shevchenko
2016-11-18 15:50 ` Guenter Roeck
2016-11-18 17:36 ` Andy Shevchenko [this message]
2016-11-19 15:55 ` Guenter Roeck
2016-11-19 16:10 ` Andy Shevchenko
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1479490602.22212.33.camel@linux.intel.com \
--to=andriy.shevchenko@linux.intel.com \
--cc=linux-watchdog@vger.kernel.org \
--cc=linux@roeck-us.net \
--cc=mika.westerberg@linux.intel.com \
--cc=wim@iguana.be \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).