From: Radu Rendec <rrendec@arista.com>
To: Guenter Roeck <linux@roeck-us.net>
Cc: Wim Van Sebroeck <wim@iguana.be>, linux-watchdog@vger.kernel.org
Subject: Re: [PATCH v3 4/4] watchdog: i6300esb: remove info message and version number
Date: Fri, 27 Oct 2017 11:58:41 +0100 [thread overview]
Message-ID: <1509101921.5684.3.camel@arista.com> (raw)
In-Reply-To: <bf7f6cc8-73da-19a1-d54c-438b5ede1b57@roeck-us.net>
On Thu, 2017-10-26 at 18:05 -0700, Guenter Roeck wrote:
> On 10/26/2017 09:10 AM, Radu Rendec wrote:
> > The initial info message (early in the esb_probe() function) is not very
> > useful and we already have a message on successful probe, which includes
> > device identification. If the probe fails (e.g. PCI related errors),
> > additional messages are printed anyway.
> >
> > The version number was only used in the initial info message. Other than
> > that, it serves no useful purpose and it ran out of favor upstream
> > anyway.
> >
> > Signed-off-by: Radu Rendec <rrendec@arista.com>
>
> Reviewed-by: Guenter Roeck <linux@roeck-us.net>
>
> ... and thanks a lot for doing this!
You're welcome. Thanks for reviewing this and for all the input!
We also benefit from this work - on the long run, it's always easier to
work with upstream and get changes accepted than maintain custom
patches.
Best,
Radu
next prev parent reply other threads:[~2017-10-27 10:58 UTC|newest]
Thread overview: 26+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-10-16 18:25 [PATCH 1/3] watchdog: i6300esb: use the watchdog subsystem Radu Rendec
2017-10-16 18:25 ` [PATCH 2/3] watchdog: i6300esb: support multiple devices Radu Rendec
2017-10-22 17:05 ` [2/3] " Guenter Roeck
2017-10-16 18:25 ` [PATCH 3/3] watchdog: i6300esb: do not hardcode heartbeat limits Radu Rendec
2017-10-22 17:09 ` [3/3] " Guenter Roeck
2017-10-25 15:39 ` [PATCH v2 1/4] watchdog: i6300esb: use the watchdog subsystem Radu Rendec
2017-10-25 20:51 ` Guenter Roeck
2017-10-25 15:39 ` [PATCH v2 2/4] watchdog: i6300esb: support multiple devices Radu Rendec
2017-10-25 20:55 ` Guenter Roeck
2017-10-26 11:35 ` Radu Rendec
2017-10-26 13:51 ` Guenter Roeck
2017-10-26 16:10 ` [PATCH v3 1/4] watchdog: i6300esb: use the watchdog subsystem Radu Rendec
2017-10-27 1:03 ` Guenter Roeck
2017-10-26 16:10 ` [PATCH v3 2/4] watchdog: i6300esb: support multiple devices Radu Rendec
2017-10-27 1:02 ` Guenter Roeck
2017-10-27 1:04 ` Guenter Roeck
2017-10-26 16:10 ` [PATCH v3 3/4] watchdog: i6300esb: do not hardcode heartbeat limits Radu Rendec
2017-10-27 1:04 ` Guenter Roeck
2017-10-26 16:10 ` [PATCH v3 4/4] watchdog: i6300esb: remove info message and version number Radu Rendec
2017-10-27 1:05 ` Guenter Roeck
2017-10-27 10:58 ` Radu Rendec [this message]
2017-10-25 15:39 ` [PATCH v2 3/4] watchdog: i6300esb: do not hardcode heartbeat limits Radu Rendec
2017-10-25 20:56 ` Guenter Roeck
2017-10-25 15:39 ` [PATCH v2 4/4] watchdog: i6300esb: bump version to 0.6 Radu Rendec
2017-10-25 20:57 ` Guenter Roeck
2017-10-22 17:02 ` [1/3] watchdog: i6300esb: use the watchdog subsystem Guenter Roeck
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1509101921.5684.3.camel@arista.com \
--to=rrendec@arista.com \
--cc=linux-watchdog@vger.kernel.org \
--cc=linux@roeck-us.net \
--cc=wim@iguana.be \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox