From: Lyude Paul <lyude@redhat.com>
To: Guenter Roeck <linux@roeck-us.net>, Wim Van Sebroeck <wim@iguana.be>
Cc: linux-watchdog@vger.kernel.org, linux-kernel@vger.kernel.org,
"Zoltán Böszörményi" <zboszor@pr.hu>
Subject: Re: [02/12] watchdog: sp5100_tco: Fix watchdog disable bit
Date: Tue, 16 Jan 2018 14:34:49 -0500 [thread overview]
Message-ID: <1516131289.18904.6.camel@redhat.com> (raw)
In-Reply-To: <1514149448-20214-3-git-send-email-linux@roeck-us.net>
On Sun, 2017-12-24 at 13:03 -0800, Guenter Roeck wrote:
> According to all published information, the watchdog disable bit for SB800
> compatible controllers is bit 1 of PM register 0x48, not bit 2. For the
> most part that doesn't matter in practice, since the bit has to be cleared
> to enable watchdog address decoding, which is the default setting, but it
> still needs to be fixed.
Reviewed-by: Lyude Paul <lyude@redhat.com>
>
> Cc: Zoltán Böszörményi <zboszor@pr.hu>
> Signed-off-by: Guenter Roeck <linux@roeck-us.net>
> ---
> drivers/watchdog/sp5100_tco.h | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/watchdog/sp5100_tco.h b/drivers/watchdog/sp5100_tco.h
> index f495fe03887a..2622cfe23dc1 100644
> --- a/drivers/watchdog/sp5100_tco.h
> +++ b/drivers/watchdog/sp5100_tco.h
> @@ -52,7 +52,7 @@
> #define SB800_PM_WATCHDOG_CONFIG 0x4C
>
> #define SB800_PCI_WATCHDOG_DECODE_EN (1 << 0)
> -#define SB800_PM_WATCHDOG_DISABLE (1 << 2)
> +#define SB800_PM_WATCHDOG_DISABLE (1 << 1)
> #define SB800_PM_WATCHDOG_SECOND_RES (3 << 0)
> #define SB800_ACPI_MMIO_DECODE_EN (1 << 0)
> #define SB800_ACPI_MMIO_SEL (1 << 1)
--
Cheers,
Lyude Paul
next prev parent reply other threads:[~2018-01-16 19:34 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-12-24 21:03 [PATCH 00/12] watchdog: sp5100_tco: Various improvements Guenter Roeck
2017-12-24 21:03 ` [PATCH 01/12] watchdog: sp5100_tco: Always use SP5100_IO_PM_{INDEX_REG,DATA_REG} Guenter Roeck
2018-01-16 19:34 ` [01/12] watchdog: sp5100_tco: Always use SP5100_IO_PM_{INDEX_REG, DATA_REG} Lyude Paul
2018-01-16 20:11 ` Guenter Roeck
2018-01-16 20:17 ` Lyude Paul
2018-01-16 22:37 ` Guenter Roeck
2018-01-17 1:10 ` Guenter Roeck
2017-12-24 21:03 ` [PATCH 02/12] watchdog: sp5100_tco: Fix watchdog disable bit Guenter Roeck
2018-01-16 19:34 ` Lyude Paul [this message]
2018-01-04 11:41 ` [PATCH 00/12] watchdog: sp5100_tco: Various improvements Boszormenyi Zoltan
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1516131289.18904.6.camel@redhat.com \
--to=lyude@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-watchdog@vger.kernel.org \
--cc=linux@roeck-us.net \
--cc=wim@iguana.be \
--cc=zboszor@pr.hu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).