linux-watchdog.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Jerry Hoemann <jerry.hoemann@hpe.com>
To: wim@linux-watchdog.org, linux@roeck-us.net
Cc: linux-watchdog@vger.kernel.org, linux-kernel@vger.kernel.org,
	Jerry Hoemann <jerry.hoemann@hpe.com>
Subject: [PATCH v2 1/5] watchdog: hpwdt: Initialize pretimeout from module parameter.
Date: Wed,  8 Aug 2018 13:13:23 -0600	[thread overview]
Message-ID: <1533755607-71418-2-git-send-email-jerry.hoemann@hpe.com> (raw)
In-Reply-To: <1533755607-71418-1-git-send-email-jerry.hoemann@hpe.com>

When the pretimeout is specified as a module parameter, the
value should be reflected in hpwdt_dev.pretimeout.  The default
(on) case is correct.  But, when disabling pretimeout, the value
should be set to zero in hpwdt_dev.

When compiling w/o CONFIG_HPWDT_NMI_DECODING defined, the pretimeout
module parameter is ignored and the value internally will be 0.

Signed-off-by: Jerry Hoemann <jerry.hoemann@hpe.com>
---
 drivers/watchdog/hpwdt.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/drivers/watchdog/hpwdt.c b/drivers/watchdog/hpwdt.c
index 9dc62a4..fae9364 100644
--- a/drivers/watchdog/hpwdt.c
+++ b/drivers/watchdog/hpwdt.c
@@ -205,9 +205,7 @@ static int hpwdt_pretimeout(unsigned int ulReason, struct pt_regs *regs)
 	.min_timeout	= 1,
 	.max_timeout	= HPWDT_MAX_TIMER,
 	.timeout	= DEFAULT_MARGIN,
-#ifdef CONFIG_HPWDT_NMI_DECODING
 	.pretimeout	= PRETIMEOUT_SEC,
-#endif
 };
 
 
@@ -313,6 +311,8 @@ static int hpwdt_init_one(struct pci_dev *dev,
 	if (watchdog_init_timeout(&hpwdt_dev, soft_margin, NULL))
 		dev_warn(&dev->dev, "Invalid soft_margin: %d.\n", soft_margin);
 
+	hpwdt_dev.pretimeout = pretimeout ? PRETIMEOUT_SEC : 0;
+
 	hpwdt_dev.parent = &dev->dev;
 	retval = watchdog_register_device(&hpwdt_dev);
 	if (retval < 0) {
-- 
1.8.3.1


  reply	other threads:[~2018-08-08 21:42 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-08-08 19:13 [PATCH v2 0/5] watchdog: hpwdt: Bug Fixes/Enhancement Jerry Hoemann
2018-08-08 19:13 ` Jerry Hoemann [this message]
2018-08-14 13:30   ` [PATCH v2 1/5] watchdog: hpwdt: Initialize pretimeout from module parameter Guenter Roeck
2018-08-08 19:13 ` [PATCH v2 2/5] watchdog: hpwdt: Claim NMI from iLO Jerry Hoemann
2018-08-14 13:30   ` Guenter Roeck
2018-08-08 19:13 ` [PATCH v2 3/5] watchdog: hpwdt: Display module parameters Jerry Hoemann
2018-08-14 13:31   ` Guenter Roeck
2018-08-08 19:13 ` [PATCH v2 4/5] watchdog: hpwdt: Module paramerter alias Jerry Hoemann
2018-08-14 13:31   ` Guenter Roeck
2018-08-08 19:13 ` [PATCH v2 5/5] watchdog: hpwdt: Update version number Jerry Hoemann
2018-08-14 13:32   ` Guenter Roeck
2018-09-06  6:03 ` [PATCH v2 0/5] watchdog: hpwdt: Bug Fixes/Enhancement Jerry Hoemann

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1533755607-71418-2-git-send-email-jerry.hoemann@hpe.com \
    --to=jerry.hoemann@hpe.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-watchdog@vger.kernel.org \
    --cc=linux@roeck-us.net \
    --cc=wim@linux-watchdog.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).