From mboxrd@z Thu Jan  1 00:00:00 1970
Return-path: <linux-watchdog-owner@vger.kernel.org>
Received: from mailout3.samsung.com ([203.254.224.33]:60082 "EHLO
        mailout3.samsung.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
        with ESMTP id S1751258AbdCNNap (ORCPT
        <rfc822;linux-watchdog@vger.kernel.org>);
        Tue, 14 Mar 2017 09:30:45 -0400
From: Bartlomiej Zolnierkiewicz <b.zolnierkie@samsung.com>
To: Krzysztof Kozlowski <krzk@kernel.org>
Cc: linux-arm-kernel@lists.infradead.org,
        Wim Van Sebroeck <wim@iguana.be>,
        Guenter Roeck <linux@roeck-us.net>,
        Rob Herring <robh+dt@kernel.org>,
        Kukjin Kim <kgene@kernel.org>,
        Javier Martinez Canillas <javier@osg.samsung.com>,
        linux-watchdog@vger.kernel.org, devicetree@vger.kernel.org,
        linux-kernel@vger.kernel.org, linux-samsung-soc@vger.kernel.org
Subject: Re: [PATCH v2 4/8] ARM: dts: s3c64xx: Enable watchdog on all S3C64xx
 boards
Date: Tue, 14 Mar 2017 14:30:29 +0100
Message-id: <1633762.1QWnRjdako@amdc3058>
In-reply-to: <CAJKOXPeCK1cjY78+PfcTprTnyXJ1k9zcUj8nW7onG8y0TWGzzQ@mail.gmail.com>
MIME-version: 1.0
Content-transfer-encoding: 7Bit
Content-type: text/plain; charset=us-ascii
References: <20170311172527.16368-1-krzk@kernel.org>
 <4386279.iJpUOasmTG@amdc3058>
 <CAJKOXPeCK1cjY78+PfcTprTnyXJ1k9zcUj8nW7onG8y0TWGzzQ@mail.gmail.com>
 <CGME20170314133035epcas1p47a04430402688bbb6baebad69b8e5b24@epcas1p4.samsung.com>
Sender: linux-watchdog-owner@vger.kernel.org
List-Id: linux-watchdog@vger.kernel.org

On Tuesday, March 14, 2017 03:04:28 PM Krzysztof Kozlowski wrote:
> On Tue, Mar 14, 2017 at 2:58 PM, Bartlomiej Zolnierkiewicz
> <b.zolnierkie@samsung.com> wrote:
> >
> > Hi,
> >
> > On Saturday, March 11, 2017 07:25:23 PM Krzysztof Kozlowski wrote:
> >> Watchdog module does not have external dependencies so it can be safely
> >> enabled in s3c64xx.dtsi thus making it available for all S3C64xx-based
> >> boards.
> >>
> >> Signed-off-by: Krzysztof Kozlowski <krzk@kernel.org>
> >
> > Please first fix the driver w.r.t. infinite interrupt in soft mode
> > issue and only then enable it on more hardware.  IOW this patch
> > should be placed after patch #7 in the series.
> 
> The soft-interrupt mode is not the default one so this should not
> cause any issues by default but I got your point. Makes sense. The
> pity is the timing. There wasn't much interest in the patchset (no
> comments since 24 of Feb) so I merged it yesterday evening. Does it
> brake any platform/board?

OK, let it be as it as it doesn't break the default setup.

However please consider the fact that posting revised patches
(v2 was posted *yesterday*) for a review and then merging them
the same day is not a good practice..

Best regards,
--
Bartlomiej Zolnierkiewicz
Samsung R&D Institute Poland
Samsung Electronics