From: Vivien Didelot <vivien.didelot@savoirfairelinux.com>
To: Guenter Roeck <linux@roeck-us.net>
Cc: linux-watchdog <linux-watchdog@vger.kernel.org>,
Wim Van Sebroeck <wim@iguana.be>,
linux-kernel <linux-kernel@vger.kernel.org>,
kernel <kernel@savoirfairelinux.com>
Subject: Re: [v2,2/3] watchdog: max63xx: add GPIO support
Date: Mon, 22 Jun 2015 16:43:43 -0400 (EDT) [thread overview]
Message-ID: <1645175105.110998.1435005823701.JavaMail.zimbra@savoirfairelinux.com> (raw)
In-Reply-To: <20150622165327.GA1189@roeck-us.net>
Hi Guenter,
On Jun 22, 2015, at 12:53 PM, Guenter Roeck linux@roeck-us.net wrote:
> On Wed, Jun 17, 2015 at 06:58:59PM -0400, Vivien Didelot wrote:
>> Introduce a new struct max63xx_platform_data to support MAX63xx watchdog
>> chips connected via GPIO. A platform code can fill this structure with
>> GPIO numbers for WDI and WDSET pins to enable GPIO support in the code.
>>
>> The driver takes care of requesting and releasing the GPIOs.
>>
>> Signed-off-by: Vivien Didelot <vivien.didelot@savoirfairelinux.com>
>
> would it be possible to use gpiod functions ?
It might be, but I never played with it yet though. I'm using integer-based
GPIOs from a TCA6424 on an x86 platform (no Device Tree). Is it ok to keep
max63xx_gpio_{ping,set} for legacy GPIOs, and let someone add
max63xx_gpiod_{ping,set} if there is a need?
Thanks,
-v
next prev parent reply other threads:[~2015-06-22 20:43 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-06-17 22:58 [PATCH v2 1/3] watchdog: max63xx: dynamically allocate device Vivien Didelot
2015-06-17 22:58 ` [PATCH v2 2/3] watchdog: max63xx: add GPIO support Vivien Didelot
2015-06-22 16:53 ` [v2,2/3] " Guenter Roeck
2015-06-22 20:43 ` Vivien Didelot [this message]
2015-06-27 16:17 ` Guenter Roeck
2015-06-30 5:21 ` Vivien Didelot
2015-06-17 22:59 ` [PATCH v2 3/3] watchdog: max63xx: add heartbeat to platform data Vivien Didelot
2015-06-22 16:59 ` [v2,3/3] " Guenter Roeck
2015-06-22 20:46 ` Vivien Didelot
2015-06-22 16:41 ` [v2,1/3] watchdog: max63xx: dynamically allocate device Guenter Roeck
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1645175105.110998.1435005823701.JavaMail.zimbra@savoirfairelinux.com \
--to=vivien.didelot@savoirfairelinux.com \
--cc=kernel@savoirfairelinux.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-watchdog@vger.kernel.org \
--cc=linux@roeck-us.net \
--cc=wim@iguana.be \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox