From mboxrd@z Thu Jan 1 00:00:00 1970 Return-path: Received: from mailout3.w1.samsung.com ([210.118.77.13]:65520 "EHLO mailout3.w1.samsung.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753225Ab3J3Omv (ORCPT ); Wed, 30 Oct 2013 10:42:51 -0400 From: Tomasz Figa To: Leela Krishna Amudala Cc: linux-samsung-soc@vger.kernel.org, kgene.kim@samsung.com, wim@iguana.be, devicetree@vger.kernel.org, dianders@chromium.org, linux-watchdog@vger.kernel.org, cpgs@samsung.com, sachin.kamat@linaro.org Subject: Re: [PATCH V4 1/3] ARM: dts: Add pmu sysreg node to Exynos5 dtsi file Date: Wed, 30 Oct 2013 15:42:47 +0100 Message-id: <1713455.GWPmumZDIq@amdc1227> In-reply-to: <1383126673-29033-2-git-send-email-l.krishna@samsung.com> References: <1383126673-29033-1-git-send-email-l.krishna@samsung.com> <1383126673-29033-2-git-send-email-l.krishna@samsung.com> MIME-version: 1.0 Content-transfer-encoding: 7Bit Content-type: text/plain; charset=us-ascii Sender: linux-watchdog-owner@vger.kernel.org List-Id: linux-watchdog@vger.kernel.org Hi Leela, On Wednesday 30 of October 2013 15:21:11 Leela Krishna Amudala wrote: > This patch adds pmusysreg node to Exynos5 dtsi file to handle PMU > register accesses in a centralized way using syscon driver > > Signed-off-by: Leela Krishna Amudala > --- > arch/arm/boot/dts/exynos5.dtsi | 5 +++++ > 1 file changed, 5 insertions(+) > > diff --git a/arch/arm/boot/dts/exynos5.dtsi b/arch/arm/boot/dts/exynos5.dtsi > index e52b038..918e732 100644 > --- a/arch/arm/boot/dts/exynos5.dtsi > +++ b/arch/arm/boot/dts/exynos5.dtsi > @@ -106,4 +106,9 @@ > #size-cells = <0>; > status = "disabled"; > }; > + > + pmu_sys_reg: pmusysreg@1004000 { Please keep the node name generic, syscon should be fine. Also there is a typo in unit-address suffix. The label could also have a better name, like pmu_syscon. Best regards, Tomasz > + compatible = "syscon"; > + reg = <0x10040000 0x5000>; > + }; > }; >