Linux Watchdog driver development
 help / color / mirror / Atom feed
From: "Rob Herring (Arm)" <robh@kernel.org>
To: Kathiravan Thirumoorthy <kathiravan.thirumoorthy@oss.qualcomm.com>
Cc: linux-kernel@vger.kernel.org,
	Konrad Dybcio <konradybcio@kernel.org>,
	 linux-watchdog@vger.kernel.org, devicetree@vger.kernel.org,
	 Conor Dooley <conor+dt@kernel.org>,
	Bjorn Andersson <andersson@kernel.org>,
	 linux-arm-msm@vger.kernel.org,
	Krzysztof Kozlowski <krzk+dt@kernel.org>,
	 Wim Van Sebroeck <wim@linux-watchdog.org>,
	 Guenter Roeck <linux@roeck-us.net>
Subject: Re: [PATCH RFC 3/6] dt-bindings: watchdog: Add Qualcomm restart reason binding
Date: Tue, 08 Apr 2025 06:41:37 -0500	[thread overview]
Message-ID: <174411249716.1431691.14031212310455675992.robh@kernel.org> (raw)
In-Reply-To: <20250408-wdt_reset_reason-v1-3-e6ec30c2c926@oss.qualcomm.com>


On Tue, 08 Apr 2025 14:19:53 +0530, Kathiravan Thirumoorthy wrote:
> Add a devicetree binding for the Qualcomm IPQ SOCs restart reason
> information region found in the IMEM, allowing the system to identify
> the cause of a restart.
> 
> Signed-off-by: Kathiravan Thirumoorthy <kathiravan.thirumoorthy@oss.qualcomm.com>
> ---
>  .../bindings/watchdog/qcom,restart-reason.yaml     | 46 ++++++++++++++++++++++
>  1 file changed, 46 insertions(+)
> 

My bot found errors running 'make dt_binding_check' on your patch:

yamllint warnings/errors:

dtschema/dtc warnings/errors:
/builds/robherring/dt-review-ci/linux/Documentation/devicetree/bindings/watchdog/qcom,restart-reason.example.dtb: imem@8600000 (qcom,ipq5424-imem): 'restart-reason@7b0' does not match any of the regexes: '^pil-reloc@[0-9a-f]+$', 'pinctrl-[0-9]+'
	from schema $id: http://devicetree.org/schemas/sram/qcom,imem.yaml#

doc reference errors (make refcheckdocs):

See https://patchwork.ozlabs.org/project/devicetree-bindings/patch/20250408-wdt_reset_reason-v1-3-e6ec30c2c926@oss.qualcomm.com

The base for the series is generally the latest rc1. A different dependency
should be noted in *this* patch.

If you already ran 'make dt_binding_check' and didn't see the above
error(s), then make sure 'yamllint' is installed and dt-schema is up to
date:

pip3 install dtschema --upgrade

Please check and re-submit after running the above command yourself. Note
that DT_SCHEMA_FILES can be set to your schema file to speed up checking
your schema. However, it must be unset to test all examples with your schema.


  reply	other threads:[~2025-04-08 11:41 UTC|newest]

Thread overview: 22+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-04-08  8:49 [PATCH RFC 0/6] Add support to read the restart reason from IMEM Kathiravan Thirumoorthy
2025-04-08  8:49 ` [PATCH RFC 1/6] dt-bindings: sram: qcom,imem: Document IPQ5424 compatible Kathiravan Thirumoorthy
2025-04-09  6:58   ` Krzysztof Kozlowski
2025-04-11  4:57     ` Kathiravan Thirumoorthy
2025-04-08  8:49 ` [PATCH RFC 2/6] arm64: dts: qcom: ipq5424: Add the IMEM node Kathiravan Thirumoorthy
2025-04-09 18:41   ` Konrad Dybcio
2025-04-11  5:01     ` Kathiravan Thirumoorthy
2025-04-11  9:03       ` Konrad Dybcio
2025-04-11  9:17         ` Kathiravan Thirumoorthy
2025-04-08  8:49 ` [PATCH RFC 3/6] dt-bindings: watchdog: Add Qualcomm restart reason binding Kathiravan Thirumoorthy
2025-04-08 11:41   ` Rob Herring (Arm) [this message]
2025-04-09  7:00   ` Krzysztof Kozlowski
2025-04-11  5:25     ` Kathiravan Thirumoorthy
2025-04-08  8:49 ` [PATCH RFC 4/6] dt-bindings: sram: qcom,imem: add the support for restart reason Kathiravan Thirumoorthy
2025-04-09  7:02   ` Krzysztof Kozlowski
2025-04-08  8:49 ` [PATCH RFC 5/6] watchdog: qcom-wdt: add support to read the restart reason from IMEM Kathiravan Thirumoorthy
2025-04-08 12:33   ` Guenter Roeck
2025-04-11  5:29     ` Kathiravan Thirumoorthy
2025-04-09  7:03   ` Krzysztof Kozlowski
2025-04-11  5:34     ` Kathiravan Thirumoorthy
2025-04-08  8:49 ` [PATCH RFC 6/6] arm64: dts: qcom: ipq5424: add node for the restart reason information Kathiravan Thirumoorthy
2025-04-09 18:49 ` [PATCH RFC 0/6] Add support to read the restart reason from IMEM Konrad Dybcio

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=174411249716.1431691.14031212310455675992.robh@kernel.org \
    --to=robh@kernel.org \
    --cc=andersson@kernel.org \
    --cc=conor+dt@kernel.org \
    --cc=devicetree@vger.kernel.org \
    --cc=kathiravan.thirumoorthy@oss.qualcomm.com \
    --cc=konradybcio@kernel.org \
    --cc=krzk+dt@kernel.org \
    --cc=linux-arm-msm@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-watchdog@vger.kernel.org \
    --cc=linux@roeck-us.net \
    --cc=wim@linux-watchdog.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox