Linux Watchdog driver development
 help / color / mirror / Atom feed
From: "Rob Herring (Arm)" <robh@kernel.org>
To: Hrishabh Rajput <hrishabh.rajput@oss.qualcomm.com>
Cc: Konrad Dybcio <konradybcio@kernel.org>,
	 Guenter Roeck <linux@roeck-us.net>,
	 Krzysztof Kozlowski <krzk+dt@kernel.org>,
	 Conor Dooley <conor+dt@kernel.org>,
	devicetree@vger.kernel.org,  linux-arm-msm@vger.kernel.org,
	linux-watchdog@vger.kernel.org,  linux-kernel@vger.kernel.org,
	Bjorn Andersson <andersson@kernel.org>,
	 Wim Van Sebroeck <wim@linux-watchdog.org>
Subject: Re: [PATCH 1/2] dt-bindings: Add binding for gunyah watchdog
Date: Wed, 03 Sep 2025 18:27:42 -0500	[thread overview]
Message-ID: <175694204303.3260042.16528672909501752752.robh@kernel.org> (raw)
In-Reply-To: <20250903-gunyah_watchdog-v1-1-3ae690530e4b@oss.qualcomm.com>


On Wed, 03 Sep 2025 19:33:59 +0000, Hrishabh Rajput wrote:
> The Gunyah Hypervisor applies a devicetree overlay providing the
> pretimeout interrupt for the Gunyah Watchdog that it will be using to
> notify watchdog's pretimeout event. Add the DT bindings that Gunyah
> adheres to for the hypervisor and watchdog.
> 
> Signed-off-by: Hrishabh Rajput <hrishabh.rajput@oss.qualcomm.com>
> ---
>  .../bindings/watchdog/qcom,gh-watchdog.yaml        | 76 ++++++++++++++++++++++
>  MAINTAINERS                                        |  1 +
>  2 files changed, 77 insertions(+)
> 

My bot found errors running 'make dt_binding_check' on your patch:

yamllint warnings/errors:

dtschema/dtc warnings/errors:
Error: Documentation/devicetree/bindings/watchdog/qcom,gh-watchdog.example.dts:37.3-38.1 syntax error
FATAL ERROR: Unable to parse input tree
make[2]: *** [scripts/Makefile.dtbs:131: Documentation/devicetree/bindings/watchdog/qcom,gh-watchdog.example.dtb] Error 1
make[2]: *** Waiting for unfinished jobs....
make[1]: *** [/builds/robherring/dt-review-ci/linux/Makefile:1519: dt_binding_check] Error 2
make: *** [Makefile:248: __sub-make] Error 2

doc reference errors (make refcheckdocs):

See https://patchwork.ozlabs.org/project/devicetree-bindings/patch/20250903-gunyah_watchdog-v1-1-3ae690530e4b@oss.qualcomm.com

The base for the series is generally the latest rc1. A different dependency
should be noted in *this* patch.

If you already ran 'make dt_binding_check' and didn't see the above
error(s), then make sure 'yamllint' is installed and dt-schema is up to
date:

pip3 install dtschema --upgrade

Please check and re-submit after running the above command yourself. Note
that DT_SCHEMA_FILES can be set to your schema file to speed up checking
your schema. However, it must be unset to test all examples with your schema.


  reply	other threads:[~2025-09-03 23:27 UTC|newest]

Thread overview: 29+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-09-03 19:33 [PATCH 0/2] Add support for Gunyah Watchdog Hrishabh Rajput via B4 Relay
2025-09-03 19:33 ` [PATCH 1/2] dt-bindings: Add binding for gunyah watchdog Hrishabh Rajput via B4 Relay
2025-09-03 23:27   ` Rob Herring (Arm) [this message]
2025-09-04  9:52   ` Krzysztof Kozlowski
2025-09-04 10:16     ` Pavan Kondeti
2025-09-04 10:49       ` Krzysztof Kozlowski
2025-09-04 10:59         ` Krzysztof Kozlowski
2025-09-04 12:29           ` Pavan Kondeti
2025-09-04 13:07     ` Hrishabh Rajput
2025-09-04 13:17       ` Krzysztof Kozlowski
2025-09-04 19:03         ` Hrishabh Rajput
2025-09-03 19:34 ` [PATCH 2/2] watchdog: Add driver for Gunyah Watchdog Hrishabh Rajput via B4 Relay
2025-09-03 20:13   ` Bjorn Andersson
2025-09-04 11:40     ` Hrishabh Rajput
2025-09-04 13:47       ` Bjorn Andersson
2025-09-04 17:11   ` Pavan Kondeti
2025-09-05  9:19     ` Konrad Dybcio
2025-09-04  0:10 ` [PATCH 0/2] Add support " Rob Herring
2025-09-04 11:31   ` Konrad Dybcio
2025-09-04 22:51     ` Rob Herring
2025-09-05  0:00       ` Pavan Kondeti
2025-09-05 10:18         ` Konrad Dybcio
2025-09-08  5:49           ` Pavan Kondeti
2025-09-12 11:16             ` Konrad Dybcio
2025-09-04 14:39   ` Hrishabh Rajput
2025-09-04  7:13 ` Neil Armstrong
2025-09-04  9:18   ` Pavan Kondeti
2025-09-04 13:53     ` Bjorn Andersson
2025-09-04 17:05       ` Pavan Kondeti

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=175694204303.3260042.16528672909501752752.robh@kernel.org \
    --to=robh@kernel.org \
    --cc=andersson@kernel.org \
    --cc=conor+dt@kernel.org \
    --cc=devicetree@vger.kernel.org \
    --cc=hrishabh.rajput@oss.qualcomm.com \
    --cc=konradybcio@kernel.org \
    --cc=krzk+dt@kernel.org \
    --cc=linux-arm-msm@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-watchdog@vger.kernel.org \
    --cc=linux@roeck-us.net \
    --cc=wim@linux-watchdog.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox