From: Russell King - ARM Linux <linux@arm.linux.org.uk>
To: viresh kumar <viresh.linux@gmail.com>
Cc: Jamie Iles <jamie@jamieiles.com>,
Wim Van Sebroeck <wim@iguana.be>,
linux-watchdog@vger.kernel.org,
linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH] watchdog: add support for the Synopsys DesignWare WDT
Date: Wed, 12 Jan 2011 09:07:01 +0000 [thread overview]
Message-ID: <20110112090701.GT11039@n2100.arm.linux.org.uk> (raw)
In-Reply-To: <AANLkTim2LJVA+qJNqYd2uPNKjP54kuyvsZ7-T3jSJsta@mail.gmail.com>
On Wed, Jan 12, 2011 at 02:27:47PM +0530, viresh kumar wrote:
> > I think this is right, it's perfectly valid for a platform to return
> > NULL as a clk and you can pass that to clk_enable().
> >
>
> I agree on the first part: NULL can be returned from clk_get(), but
> passing NULL to clk_enable and clk_get_rate doesn't look fine to me.
Whatever non-error cookie clk_get() passes out, clk_enable() etc must
eat, even if it contains dead flies rather than currants. It's not
for the driver to make decisions on what clk_enable() et.al. accept,
other than as documented by the clk API - which says that errors from
clk_get() are indicated by IS_ERR(clk).
If IS_ERR(clk) is false, the driver _must_ assume that there is no error
and clk_enable() etc will accept the clk.
next prev parent reply other threads:[~2011-01-12 9:07 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-01-10 15:59 [PATCH] watchdog: add support for the Synopsys DesignWare WDT Jamie Iles
2011-01-12 5:16 ` viresh kumar
2011-01-12 8:24 ` Jamie Iles
2011-01-12 8:57 ` viresh kumar
2011-01-12 9:07 ` Russell King - ARM Linux [this message]
2011-01-12 11:30 ` Jamie Iles
2011-01-12 11:38 ` viresh kumar
2011-01-12 12:33 ` Jamie Iles
2011-01-21 18:08 ` Jamie Iles
2011-01-24 4:06 ` viresh kumar
-- strict thread matches above, loose matches on Subject: below --
2011-01-10 10:55 Jamie Iles
2011-01-10 13:21 ` Wim Van Sebroeck
2011-01-10 13:33 ` Jamie Iles
2011-01-10 13:58 ` Wim Van Sebroeck
2010-11-25 16:09 Jamie Iles
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20110112090701.GT11039@n2100.arm.linux.org.uk \
--to=linux@arm.linux.org.uk \
--cc=jamie@jamieiles.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-watchdog@vger.kernel.org \
--cc=viresh.linux@gmail.com \
--cc=wim@iguana.be \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).