* && versus &
@ 2011-02-21 18:36 Toralf Förster
2011-02-21 19:21 ` Wim Van Sebroeck
0 siblings, 1 reply; 4+ messages in thread
From: Toralf Förster @ 2011-02-21 18:36 UTC (permalink / raw)
To: wim; +Cc: linux-watchdog
Hello,
Im wondering about this line in drivers/watchdog/sch311x_wdt.c:
if (sch311x_sio_inb(sio_config_port, 0x30) && 0x01 == 0)
is this intended ?
--
MfG/Kind regards
Toralf Förster
pgp finger print: 7B1A 07F4 EC82 0F90 D4C2 8936 872A E508 7DB6 9DA3
^ permalink raw reply [flat|nested] 4+ messages in thread
* || versus |
@ 2011-02-21 18:43 Toralf Förster
2011-02-21 19:31 ` Wim Van Sebroeck
0 siblings, 1 reply; 4+ messages in thread
From: Toralf Förster @ 2011-02-21 18:43 UTC (permalink / raw)
To: wim; +Cc: linux-watchdog
I found in drivers/watchdog/w83697ug_wdt.c:
outb_p(c || 0x01, WDT_EFDR); /* set bit 0 to activate GPIO2 */
--
MfG/Kind regards
Toralf Förster
pgp finger print: 7B1A 07F4 EC82 0F90 D4C2 8936 872A E508 7DB6 9DA3
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: && versus &
2011-02-21 18:36 && versus & Toralf Förster
@ 2011-02-21 19:21 ` Wim Van Sebroeck
0 siblings, 0 replies; 4+ messages in thread
From: Wim Van Sebroeck @ 2011-02-21 19:21 UTC (permalink / raw)
To: Toralf Förster; +Cc: linux-watchdog
Hi Toralf,
> Im wondering about this line in drivers/watchdog/sch311x_wdt.c:
>
> if (sch311x_sio_inb(sio_config_port, 0x30) && 0x01 == 0)
>
> is this intended ?
This is a typo/bug.
Patch created.
Kind regards and thanks,
Wim.
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: || versus |
2011-02-21 18:43 || versus | Toralf Förster
@ 2011-02-21 19:31 ` Wim Van Sebroeck
0 siblings, 0 replies; 4+ messages in thread
From: Wim Van Sebroeck @ 2011-02-21 19:31 UTC (permalink / raw)
To: Toralf Förster; +Cc: linux-watchdog
Hi Toralf,
> I found in drivers/watchdog/w83697ug_wdt.c:
>
> outb_p(c || 0x01, WDT_EFDR); /* set bit 0 to activate GPIO2 */
Also patch created for this.
Kind regards,
Wim.
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2011-02-21 19:31 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2011-02-21 18:36 && versus & Toralf Förster
2011-02-21 19:21 ` Wim Van Sebroeck
-- strict thread matches above, loose matches on Subject: below --
2011-02-21 18:43 || versus | Toralf Förster
2011-02-21 19:31 ` Wim Van Sebroeck
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).