From: Wim Van Sebroeck <wim@iguana.be>
To: Alexander Stein <alexander.stein@systec-electronic.com>
Cc: LKML <linux-kernel@vger.kernel.org>,
Linux Watchdog Mailing List <linux-watchdog@vger.kernel.org>,
Alan Cox <alan@lxorguk.ukuu.org.uk>
Subject: Re: [RFC] [PATCH 5/10] Generic Watchdog Timer Driver
Date: Thu, 3 Mar 2011 11:38:14 +0100 [thread overview]
Message-ID: <20110303103814.GA3790@infomag.iguana.be> (raw)
In-Reply-To: <201102240921.02967.alexander.stein@systec-electronic.com>
Hi Alexander,
> On Wednesday 23 February 2011, 21:43:30 Wim Van Sebroeck wrote:
> > commit 1959ea403c69af855f5cd13e5c9b33123d2137b2
> > Author: Wim Van Sebroeck <wim@iguana.be>
> > Date: Fri Jun 18 09:45:49 2010 +0000
> >
> > watchdog: WatchDog Timer Driver Core - Part 5
> >
> > This part add's the WDIOC_SETTIMEOUT and WDIOC_GETTIMEOUT ioctl
> > functionality to the WatchDog Timer Driver Core framework.
> >
> > Signed-off-by: Alan Cox <alan@lxorguk.ukuu.org.uk>
> > Signed-off-by: Wim Van Sebroeck <wim@iguana.be>
> >
> > [snip]
>
> Any specific reason you can only specify seconds as timeout? There is no way
> to set a timeout of e.g. 500ms or 1500ms.
> You can change this by using using a struct timeval for setting a timeout.
> What do you think?
1) The current ioctl call is like this in all drivers. So changing it would break things.
2) Is there a real need for having 500ms or 1500ms? why would 1 or 2 seconds not be OK? (which are allready small timeouts for userspace anyway...)
Kind regards,
Wim.
next prev parent reply other threads:[~2011-03-03 10:38 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-02-23 20:43 [RFC] [PATCH 5/10] Generic Watchdog Timer Driver Wim Van Sebroeck
2011-02-23 21:59 ` Mike Waychison
2011-02-23 22:04 ` Wim Van Sebroeck
2011-02-24 8:21 ` Alexander Stein
2011-03-03 10:38 ` Wim Van Sebroeck [this message]
2011-03-03 12:53 ` Mark Brown
2011-03-03 16:36 ` Alexander Stein
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20110303103814.GA3790@infomag.iguana.be \
--to=wim@iguana.be \
--cc=alan@lxorguk.ukuu.org.uk \
--cc=alexander.stein@systec-electronic.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-watchdog@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).