From: Wim Van Sebroeck <wim@iguana.be>
To: Nat Gurumoorthy <natg@google.com>
Cc: Jean Delvare <khali@linux-fr.org>,
Guenter Roeck <guenter.roeck@ericsson.com>,
lm-sensors@lm-sensors.org, linux-kernel@vger.kernel.org,
linux-watchdog@vger.kernel.org, mikew@google.com
Subject: Re: [PATCH v9 1/2] Use "request_muxed_region" in it87 watchdog drivers
Date: Fri, 20 May 2011 13:48:39 +0200 [thread overview]
Message-ID: <20110520114839.GS17887@infomag.iguana.be> (raw)
In-Reply-To: <1304745647-13051-1-git-send-email-natg@google.com>
Hi Nat,
> 01 - Changes to it87 watchdog driver to use "request_muxed_region"
> Serialize access to the hardware by using "request_muxed_region" macro defined
> by Alan Cox. Call to this macro will hold off the requestor if the resource is
> currently busy.
>
> The use of the above macro makes it possible to get rid of
> spinlocks in it8712f_wdt.c and it87_wdt.c watchdog drivers.
> This also greatly simplifies the implementation of it87_wdt.c driver.
>
> "superio_enter" will return an error if call to "request_muxed_region" fails.
> Rest of the code change is to ripple an error return from superio_enter to
> the top level.
>
> Signed-off-by: Nat Gurumoorthy <natg@google.com>
Added to linux-2.6-watchdog-next.
Kind regards,
Wim.
next prev parent reply other threads:[~2011-05-20 11:48 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-05-07 5:19 [PATCH v9 0/2] Make all it87 drivers SMP safe Nat Gurumoorthy
2011-05-07 5:20 ` [PATCH v9 1/2] Use "request_muxed_region" in it87 watchdog drivers Nat Gurumoorthy
2011-05-08 4:25 ` Guenter Roeck
2011-05-20 11:48 ` Wim Van Sebroeck [this message]
2011-05-07 5:21 ` [PATCH v9 2/2] Use "request_muxed_region" in it87 hwmon drivers Nat Gurumoorthy
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20110520114839.GS17887@infomag.iguana.be \
--to=wim@iguana.be \
--cc=guenter.roeck@ericsson.com \
--cc=khali@linux-fr.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-watchdog@vger.kernel.org \
--cc=lm-sensors@lm-sensors.org \
--cc=mikew@google.com \
--cc=natg@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).