From: Wim Van Sebroeck <wim@iguana.be>
To: Jonathan McDowell <noodles@earth.li>
Cc: linux-watchdog@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] Cleanup pc87413 watchdog driver to use request_muxed_region for SuperIO area
Date: Tue, 24 May 2011 09:17:24 +0200 [thread overview]
Message-ID: <20110524071724.GD17887@infomag.iguana.be> (raw)
In-Reply-To: <20110520162054.GI28362@earth.li>
Hi Jonathan,
> > I don't think this is the correct way to do this. You do the
> > request_muxed_region only at init and exit of the module.
>
> I do a single request_muxed_region in the init function, and release it
> at the end of the init function. It's only necessary to hold the LPC
> region while the WDT functionality is enabled and the base address for
> the SWC block is retrieved.
>
> After that point all access is via the SWC region, so there's no need to
> call request_muxed_region. The call in the exit function releases the
> SWC block. We're not holding the LPC region for the entire duration of
> the driver being loaded.
Added to linux-2.6-watchdog-next.
Kind regards,
Wim.
prev parent reply other threads:[~2011-05-24 7:17 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-04-14 19:02 [PATCH] Cleanup pc87413 watchdog driver to use request_muxed_region for SuperIO area Jonathan McDowell
2011-04-30 18:25 ` Jonathan McDowell
2011-05-02 19:48 ` Wim Van Sebroeck
2011-05-20 12:21 ` Wim Van Sebroeck
2011-05-20 16:20 ` Jonathan McDowell
2011-05-24 7:17 ` Wim Van Sebroeck [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20110524071724.GD17887@infomag.iguana.be \
--to=wim@iguana.be \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-watchdog@vger.kernel.org \
--cc=noodles@earth.li \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).