From: Arnd Bergmann <arnd@arndb.de>
To: Wim Van Sebroeck <wim@iguana.be>
Cc: LKML <linux-kernel@vger.kernel.org>,
Linux Watchdog Mailing List <linux-watchdog@vger.kernel.org>,
Alan Cox <alan@lxorguk.ukuu.org.uk>
Subject: Re: [PATCH 2/10 v2] Generic Watchdog Timer Driver
Date: Sat, 18 Jun 2011 21:01:15 +0200 [thread overview]
Message-ID: <201106182101.15523.arnd@arndb.de> (raw)
In-Reply-To: <20110618172043.GC3441@infomag.iguana.be>
On Saturday 18 June 2011 19:20:43 Wim Van Sebroeck wrote:
> +/*
> * watchdog_open: open the /dev/watchdog device.
> * @inode: inode of device
> * @file: file handle to device
> @@ -202,6 +237,7 @@
> .owner = THIS_MODULE,
> .llseek = no_llseek,
> .write = watchdog_write,
> + .unlocked_ioctl = watchdog_ioctl,
> .open = watchdog_open,
> .release = watchdog_release,
> };
All the ioctl commands are compatible with their 32 bit counterparts, so
you can just set ".compat_ioctl = watchdog_ioctl" here to slightly speed
up the ioctl operation for compat tasks.
Looks good otherwise.
Arnd
prev parent reply other threads:[~2011-06-18 19:01 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-06-18 17:20 [PATCH 2/10 v2] Generic Watchdog Timer Driver Wim Van Sebroeck
2011-06-18 19:01 ` Arnd Bergmann [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=201106182101.15523.arnd@arndb.de \
--to=arnd@arndb.de \
--cc=alan@lxorguk.ukuu.org.uk \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-watchdog@vger.kernel.org \
--cc=wim@iguana.be \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).