Linux Watchdog driver development
 help / color / mirror / Atom feed
From: Wolfram Sang <w.sang@pengutronix.de>
To: Axel Lin <axel.lin@gmail.com>
Cc: linux-kernel@vger.kernel.org,
	Atsushi Nemoto <anemo@mba.ocn.ne.jp>,
	Ralf Baechle <ralf@linux-mips.org>,
	Wim Van Sebroeck <wim@iguana.be>,
	linux-watchdog@vger.kernel.org
Subject: Re: [PATCH] watchdog: Make TXX9_WDT select WATCHDOG_CORE
Date: Mon, 26 Mar 2012 08:39:56 +0200	[thread overview]
Message-ID: <20120326063956.GB24023@pengutronix.de> (raw)
In-Reply-To: <1332739713.15735.1.camel@phoenix>

[-- Attachment #1: Type: text/plain, Size: 800 bytes --]

On Mon, Mar 26, 2012 at 01:28:33PM +0800, Axel Lin wrote:
> This is required after converting to watchdog core API.
> 
> Fix below build errors:
>   LD      .tmp_vmlinux1
> drivers/built-in.o: In function `txx9wdt_probe':
> txx9wdt.c:(.init.text+0x3530): undefined reference to `watchdog_register_device'
> drivers/built-in.o: In function `txx9wdt_remove':
> txx9wdt.c:(.exit.text+0x158): undefined reference to `watchdog_unregister_device'
> make: *** [.tmp_vmlinux1] Error 1
> 
> Signed-off-by: Axel Lin <axel.lin@gmail.com>

Acked-by: Wolfram Sang <w.sang@pengutronix.de>

Can we simply fold this into the original patch?

-- 
Pengutronix e.K.                           | Wolfram Sang                |
Industrial Linux Solutions                 | http://www.pengutronix.de/  |

[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 198 bytes --]

  reply	other threads:[~2012-03-26  6:40 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-03-26  5:28 [PATCH] watchdog: Make TXX9_WDT select WATCHDOG_CORE Axel Lin
2012-03-26  6:39 ` Wolfram Sang [this message]
2012-03-26  6:42   ` Axel Lin
2012-03-26 14:43     ` Wim Van Sebroeck

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20120326063956.GB24023@pengutronix.de \
    --to=w.sang@pengutronix.de \
    --cc=anemo@mba.ocn.ne.jp \
    --cc=axel.lin@gmail.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-watchdog@vger.kernel.org \
    --cc=ralf@linux-mips.org \
    --cc=wim@iguana.be \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox