From mboxrd@z Thu Jan 1 00:00:00 1970 Return-path: Received: from mail160.messagelabs.com ([216.82.253.99]:51397 "EHLO mail160.messagelabs.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750893Ab2EBXzD (ORCPT ); Wed, 2 May 2012 19:55:03 -0400 From: H Hartley Sweeten To: Linux Kernel Subject: [PATCH] watchdog: sp5100_tco.c: quiet sparse noise about using plain integer was NULL pointer Date: Wed, 2 May 2012 16:54:43 -0700 CC: , MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit Content-Disposition: inline Message-ID: <201205021654.43838.hartleys@visionengravers.com> Sender: linux-watchdog-owner@vger.kernel.org List-Id: linux-watchdog@vger.kernel.org Pointers should not be compared to plain integers. Quiets the sparse warning: warning: Using plain integer as NULL pointer Signed-off-by: H Hartley Sweeten Cc: Wim Van Sebroeck --- diff --git a/drivers/watchdog/sp5100_tco.c b/drivers/watchdog/sp5100_tco.c index 59108e4..ae5e82c 100644 --- a/drivers/watchdog/sp5100_tco.c +++ b/drivers/watchdog/sp5100_tco.c @@ -313,7 +313,7 @@ static unsigned char __devinit sp5100_tco_setupdevice(void) tcobase_phys = val; tcobase = ioremap(val, SP5100_WDT_MEM_MAP_SIZE); - if (tcobase == 0) { + if (!tcobase) { pr_err("failed to get tcobase address\n"); goto unreg_mem_region; }