Linux Watchdog driver development
 help / color / mirror / Atom feed
From: Wim Van Sebroeck <wim@iguana.be>
To: MyungJoo Ham <myungjoo.ham@samsung.com>
Cc: "Linux Watchdog Mailing List" <linux-watchdog@vger.kernel.org>,
	정재훈 <jh80.chung@samsung.com>,
	"BANAJIT GOSWAMI" <banajit.g@samsung.com>,
	"Ben Dooks" <ben-linux@fluff.org>, "Ben Dooks" <ben@simtec.co.uk>,
	"Wolfram Sang" <w.sang@pengutronix.de>
Subject: Re: [PATCH] watchdog: s3c2410-wdt: Use of_match_ptr().
Date: Thu, 3 May 2012 06:48:54 +0200	[thread overview]
Message-ID: <20120503044854.GI3074@spo001.leaseweb.com> (raw)
In-Reply-To: <4198193.124741336006837837.JavaMail.weblogic@epml09>

Hi,

> 
> > Use of_match_ptr definition for the of_match_table.
> > 
> > Signed-off-by: Wim Van Sebroeck <wim@iguana.be>
> > 
> > ---
> > 
> > Can someone compile test this?
> > 
> > Thanks,
> > Wim.
> 
> 
> I get this error. You probably need to add #include.
> 
> scripts/kconfig/conf --silentoldconfig Kconfig
>   CHK     include/linux/version.h
>   CHK     include/generated/utsrelease.h
> make[1]: `include/generated/mach-types.h' is up to date.
>   CALL    scripts/checksyscalls.sh
>   CHK     include/generated/compile.h
>   CC      drivers/watchdog/watchdog_core.o
>   CC      drivers/watchdog/watchdog_dev.o
>   CC      drivers/watchdog/s3c2410_wdt.o
>   LD      drivers/watchdog/watchdog.o
> drivers/watchdog/s3c2410_wdt.c:517:3: error: implicit declaration of function ‘of_match_ptr’
> drivers/watchdog/s3c2410_wdt.c:517:34: error: ‘s3c2410_wdt_match’ undeclared here (not in a function)
> make[2]: *** [drivers/watchdog/s3c2410_wdt.o] Error 1
> make[2]: *** Waiting for unfinished jobs....
> make[1]: *** [drivers/watchdog] Error 2
> make: *** [drivers] Error 2

Can you try with: #include <linux/of.h> ?

Thanks,
Wim.

--
To unsubscribe from this list: send the line "unsubscribe linux-watchdog" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

  reply	other threads:[~2012-05-03  4:48 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-05-03  1:00 [PATCH] watchdog: s3c2410-wdt: Use of_match_ptr() MyungJoo Ham
2012-05-03  4:48 ` Wim Van Sebroeck [this message]
  -- strict thread matches above, loose matches on Subject: below --
2012-05-02 17:40 Wim Van Sebroeck

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20120503044854.GI3074@spo001.leaseweb.com \
    --to=wim@iguana.be \
    --cc=banajit.g@samsung.com \
    --cc=ben-linux@fluff.org \
    --cc=ben@simtec.co.uk \
    --cc=jh80.chung@samsung.com \
    --cc=linux-watchdog@vger.kernel.org \
    --cc=myungjoo.ham@samsung.com \
    --cc=w.sang@pengutronix.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox