linux-watchdog.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: David Teigland <teigland@redhat.com>
To: Hans de Goede <hdegoede@redhat.com>
Cc: wim@iguana.be, linux-watchdog@vger.kernel.org
Subject: Re: [PATCH] watchdog: new option to skip ping in close
Date: Tue, 7 Aug 2012 11:23:48 -0400	[thread overview]
Message-ID: <20120807152348.GA29229@redhat.com> (raw)
In-Reply-To: <5020C980.5050601@redhat.com>

On Tue, Aug 07, 2012 at 09:53:36AM +0200, Hans de Goede wrote:
> >In the end, we need WDIOC_NOCLOSEPING to be processed by the core,
> >independent of what drivers do, since as I explained this is targeting the
> >behavior of the core framework, not the drivers.
> 
> Right, and it will be processed by the core if it is in the switch-case because:
> 
> watchdog_ioctl_op will return ENOIOCTLCMD for non driver specific custom ioctls,
> causing watchdog_ioctl() to continue into the switch case for standard ioctls!

Thanks, there's one piece I'm missing -- could you refer me to a specific
driver that returns ENOIOCTLCMD from its ioctl method?

Thanks,
Dave


  reply	other threads:[~2012-08-07 15:23 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-08-03 17:40 [PATCH] watchdog: new option to skip ping in close David Teigland
2012-08-04  9:08 ` Hans de Goede
2012-08-06 16:25   ` David Teigland
2012-08-07  7:53     ` Hans de Goede
2012-08-07 15:23       ` David Teigland [this message]
2012-08-08 20:22     ` Wim Van Sebroeck
2012-08-08 21:11       ` David Teigland

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20120807152348.GA29229@redhat.com \
    --to=teigland@redhat.com \
    --cc=hdegoede@redhat.com \
    --cc=linux-watchdog@vger.kernel.org \
    --cc=wim@iguana.be \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).