linux-watchdog.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Sascha Hauer <s.hauer@pengutronix.de>
To: Christian Gmeiner <christian.gmeiner@gmail.com>
Cc: LKML <linux-kernel@vger.kernel.org>,
	x86@kernel.org, linux-i2c@vger.kernel.org,
	linux-watchdog@vger.kernel.org,
	Thomas Gleixner <tglx@linutronix.de>
Subject: Re: [PATCH 1/3] x86: Add basic support for the Congatec CGEB BIOS interface
Date: Tue, 26 Mar 2013 09:54:54 +0100	[thread overview]
Message-ID: <20130326085454.GK1906@pengutronix.de> (raw)
In-Reply-To: <CAH9NwWdOCo642KqUXk1y5hbwdtW5RYgQnQfZFUEe4FOJzSiByQ@mail.gmail.com>

On Mon, Mar 25, 2013 at 09:31:35AM +0100, Christian Gmeiner wrote:
> Hi Sascha
> 
> 
> > +struct cgeb_pdata {
> > +       struct cgeb_board_data          *board;
> > +       int unit;
> > +};
> > +
> > +#endif /* __CONGATEC_CGEB_H */
> > diff --git a/arch/x86/platform/Makefile b/arch/x86/platform/Makefile
> > index 8d87439..9de1789 100644
> > --- a/arch/x86/platform/Makefile
> > +++ b/arch/x86/platform/Makefile
> > @@ -1,5 +1,6 @@
> >  # Platform specific code goes here
> >  obj-y  += ce4100/
> > +obj-y  += congatec/
> >  obj-y  += efi/
> >  obj-y  += geode/
> >  obj-y  += iris/
> 
> 
> Fails to build

Ups, sorry. It seems I forgot to git add
arch/x86/platform/congatec/Makefile. It should look like this:

obj-$(CONFIG_CONGATEC_CGEB) += congatec-cgeb.o

I will include this next time.


Any other comments to this series? Is the base cgeb support ok to
include?

Sascha

-- 
Pengutronix e.K.                           |                             |
Industrial Linux Solutions                 | http://www.pengutronix.de/  |
Peiner Str. 6-8, 31137 Hildesheim, Germany | Phone: +49-5121-206917-0    |
Amtsgericht Hildesheim, HRA 2686           | Fax:   +49-5121-206917-5555 |

  reply	other threads:[~2013-03-26  8:55 UTC|newest]

Thread overview: 21+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-02-12 10:02 [PATCH] Congatec CGEB base, i2c and watchdog driver support Sascha Hauer
2013-02-12 10:02 ` [PATCH 1/3] x86: Add basic support for the Congatec CGEB BIOS interface Sascha Hauer
2013-03-25  8:31   ` Christian Gmeiner
2013-03-26  8:54     ` Sascha Hauer [this message]
2013-03-26  9:24       ` Wolfram Sang
2013-03-26  9:31         ` Sascha Hauer
2013-03-26  9:38           ` Christian Gmeiner
2013-04-11  7:14             ` Christian Gmeiner
2013-04-11 11:20               ` Wolfram Sang
2013-02-12 10:02 ` [PATCH 2/3] i2c: Add Congatec CGEB I2C driver Sascha Hauer
2013-02-14 10:11   ` Wolfram Sang
2013-03-26  9:55     ` Christian Gmeiner
2013-02-12 10:02 ` [PATCH 3/3] watchdog: Add Congatec CGEB watchdog driver Sascha Hauer
2013-03-26 10:16   ` Christian Gmeiner
2013-03-26 14:33     ` Guenter Roeck
2013-04-03 15:09       ` Sascha Hauer
2013-04-03 15:30         ` Guenter Roeck
2013-04-03 17:06           ` Sascha Hauer
2013-04-03 15:16     ` Sascha Hauer
2013-02-13 14:57 ` [PATCH] Congatec CGEB base, i2c and watchdog driver support Christian Gmeiner
2013-02-14  8:35   ` Sascha Hauer

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20130326085454.GK1906@pengutronix.de \
    --to=s.hauer@pengutronix.de \
    --cc=christian.gmeiner@gmail.com \
    --cc=linux-i2c@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-watchdog@vger.kernel.org \
    --cc=tglx@linutronix.de \
    --cc=x86@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).