From: Johannes Thumshirn <johannes.thumshirn@men.de>
To: Wim Van Sebroeck <wim@iguana.be>
Cc: <linux-watchdog@vger.kernel.org>, <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH v4 1/2] watchdog: New watchdog driver for MEN A21 watchdogs
Date: Tue, 28 May 2013 10:10:53 +0200 [thread overview]
Message-ID: <20130528081053.GC818@jtlinux> (raw)
In-Reply-To: <20130527182554.GB14258@spo001.leaseweb.com>
On Mon, May 27, 2013 at 08:25:54PM +0200, Wim Van Sebroeck wrote:
[...]
> > + watchdog_set_drvdata(&a21_wdt, drv);
>
> I am missing the initialisation of the watchdog's timeout value here...
This watchdog only knows two timeout values, 1s and 30s with the constraint
that you can't go back to 30s once your in a 1s timeout without a reset of the
CPLD. I could initially set it to 30s but that would be redundant.
> For the rest this looks OK.
>
> Kind regards,
> wim.
>
This sounds pretty good.
next prev parent reply other threads:[~2013-05-28 8:09 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-05-13 20:58 [PATCH] watchdog: New watchdog driver for MEN A21 watchdogs johannes.thumshirn
2013-05-13 22:44 ` Guenter Roeck
2013-05-14 19:09 ` [PATCH v2] " johannes.thumshirn
2013-05-14 19:33 ` Joe Perches
2013-05-15 18:50 ` [PATCH v3] " johannes.thumshirn
2013-05-26 14:34 ` Wim Van Sebroeck
2013-05-27 6:45 ` AW: " Thumshirn, Johannes Tobias
2013-05-27 9:07 ` Wim Van Sebroeck
2013-05-27 18:13 ` [PATCH v4 1/2] " johannes.thumshirn
2013-05-27 18:13 ` [PATCH v4 2/2] watchdog: Add sysfs interface for MEN A21 watchdog johannes.thumshirn
2013-05-27 19:41 ` Wim Van Sebroeck
2013-05-29 8:35 ` Johannes Thumshirn
2013-05-30 22:00 ` Wim Van Sebroeck
2013-05-27 18:25 ` [PATCH v4 1/2] watchdog: New watchdog driver for MEN A21 watchdogs Wim Van Sebroeck
2013-05-28 8:10 ` Johannes Thumshirn [this message]
2013-05-28 16:22 ` Guenter Roeck
2013-05-29 8:14 ` Johannes Thumshirn
2013-05-30 21:59 ` Wim Van Sebroeck
2013-05-30 22:02 ` Guenter Roeck
2013-05-31 8:24 ` Johannes Thumshirn
2013-05-31 9:35 ` anish singh
2013-05-31 10:09 ` Guenter Roeck
2013-05-30 21:52 ` Wim Van Sebroeck
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130528081053.GC818@jtlinux \
--to=johannes.thumshirn@men.de \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-watchdog@vger.kernel.org \
--cc=wim@iguana.be \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).