From: Guenter Roeck <linux@roeck-us.net>
To: Sachin Kamat <sachin.kamat@linaro.org>
Cc: linux-watchdog@vger.kernel.org, wim@iguana.be
Subject: Re: [1/3] watchdog: at91rm9200: Remove redundant of_match_ptr
Date: Tue, 1 Oct 2013 13:48:42 -0700 [thread overview]
Message-ID: <20131001204842.GA20057@roeck-us.net> (raw)
In-Reply-To: <1380516173-6974-1-git-send-email-sachin.kamat@linaro.org>
On Mon, Sep 30, 2013 at 12:42:51PM -0000, Sachin Kamat wrote:
> The data structure of_match_ptr() protects is always compiled in.
> Hence of_match_ptr() is not needed.
>
> Signed-off-by: Sachin Kamat <sachin.kamat@linaro.org>
>
Hi Sachin,
I understand that the driver doesn't currently support to be built as module,
so of_match_ptr() is not really necessary. But unless I am missing something,
here isn't anything wrong with it either, not does it hurt to have it in place.
So what is the benefit of this series ?
Thanks,
Guenter
> ---
> drivers/watchdog/at91rm9200_wdt.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/watchdog/at91rm9200_wdt.c b/drivers/watchdog/at91rm9200_wdt.c
> index 1c75260..aa5cb56 100644
> --- a/drivers/watchdog/at91rm9200_wdt.c
> +++ b/drivers/watchdog/at91rm9200_wdt.c
> @@ -269,7 +269,7 @@ static struct platform_driver at91wdt_driver = {
> .driver = {
> .name = "at91_wdt",
> .owner = THIS_MODULE,
> - .of_match_table = of_match_ptr(at91_wdt_dt_ids),
> + .of_match_table = at91_wdt_dt_ids,
> },
> };
>
next prev parent reply other threads:[~2013-10-01 20:48 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-09-30 4:42 [PATCH 1/3] watchdog: at91rm9200: Remove redundant of_match_ptr Sachin Kamat
2013-09-30 4:42 ` [PATCH 2/3] watchdog: orion: " Sachin Kamat
2013-10-02 15:15 ` [2/3] " Guenter Roeck
2013-09-30 4:42 ` [PATCH 3/3] watchdog: sunxi: " Sachin Kamat
2013-10-02 15:16 ` [3/3] " Guenter Roeck
2013-10-01 20:48 ` Guenter Roeck [this message]
2013-10-02 6:43 ` [1/3] watchdog: at91rm9200: " Sachin Kamat
2013-10-02 15:13 ` Guenter Roeck
2013-10-02 16:08 ` Sachin Kamat
2013-10-28 6:27 ` Sachin Kamat
2013-10-29 7:46 ` [PATCH 1/3] " Wim Van Sebroeck
2013-10-29 9:38 ` Sachin Kamat
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20131001204842.GA20057@roeck-us.net \
--to=linux@roeck-us.net \
--cc=linux-watchdog@vger.kernel.org \
--cc=sachin.kamat@linaro.org \
--cc=wim@iguana.be \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).