From: Jean Delvare <jdelvare@suse.de>
To: Guenter Roeck <linux@roeck-us.net>
Cc: linux-watchdog@vger.kernel.org, Wim Van Sebroeck <wim@iguana.be>
Subject: Re: [PATCH] watchdog: Drop unnecessary include of miscdevice.h
Date: Wed, 20 Nov 2013 09:14:07 +0100 [thread overview]
Message-ID: <20131120091407.1a94acbf@endymion.delvare> (raw)
In-Reply-To: <1384896377-32382-1-git-send-email-linux@roeck-us.net>
Hi Guenter,
On Tue, 19 Nov 2013 13:26:17 -0800, Guenter Roeck wrote:
> After commit 487722cf2 (watchdog: Get rid of MODULE_ALIAS_MISCDEV
> statements) the affected drivers no longer need to include miscdevice.h.
> Only exception is rt2880_wdt.c which never needed it.
I'm surprised because I thought I did check after applying my changes
and had removed the #include <linux/miscdevice.h> every time it was OK
to do so. But apparently I missed many... Thanks for noticing.
Reviewed-by: Jean Delvare <jdelvare@suse.de>
> Signed-off-by: Guenter Roeck <linux@roeck-us.net>
> ---
> Compile tested.
>
> drivers/watchdog/bcm2835_wdt.c | 1 -
> drivers/watchdog/ep93xx_wdt.c | 1 -
> drivers/watchdog/ie6xx_wdt.c | 1 -
> drivers/watchdog/jz4740_wdt.c | 1 -
> drivers/watchdog/kempld_wdt.c | 1 -
> drivers/watchdog/max63xx_wdt.c | 1 -
> drivers/watchdog/orion_wdt.c | 1 -
> drivers/watchdog/pnx4008_wdt.c | 1 -
> drivers/watchdog/rt2880_wdt.c | 1 -
> drivers/watchdog/shwdt.c | 1 -
> drivers/watchdog/softdog.c | 1 -
> drivers/watchdog/stmp3xxx_rtc_wdt.c | 1 -
> drivers/watchdog/txx9wdt.c | 1 -
> drivers/watchdog/ux500_wdt.c | 1 -
> 14 files changed, 14 deletions(-)
> (...)
--
Jean Delvare
Suse L3 Support
prev parent reply other threads:[~2013-11-20 8:14 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-11-19 21:26 [PATCH] watchdog: Drop unnecessary include of miscdevice.h Guenter Roeck
2013-11-20 8:14 ` Jean Delvare [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20131120091407.1a94acbf@endymion.delvare \
--to=jdelvare@suse.de \
--cc=linux-watchdog@vger.kernel.org \
--cc=linux@roeck-us.net \
--cc=wim@iguana.be \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).