From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-pb0-f51.google.com ([209.85.160.51]:32920 "EHLO mail-pb0-f51.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1757008Ab3LBVg4 (ORCPT ); Mon, 2 Dec 2013 16:36:56 -0500 Date: Mon, 2 Dec 2013 13:36:54 -0800 From: Guenter Roeck To: Olof Johansson Cc: Doug Anderson , Wim Van Sebroeck , Leela Krishna Amudala , Tomasz Figa , Kukjin Kim , Ben Dooks , "linux-arm-kernel@lists.infradead.org" , "linux-samsung-soc@vger.kernel.org" , "linux-watchdog@vger.kernel.org" , "linux-kernel@vger.kernel.org" Subject: Re: [PATCH] watchdog: s3c2410_wdt: Report when the watchdog reset the system Message-ID: <20131202213654.GA4059@roeck-us.net> References: <1386008082-28740-1-git-send-email-dianders@chromium.org> <20131202202120.GA23611@roeck-us.net> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: Sender: linux-watchdog-owner@vger.kernel.org List-Id: linux-watchdog@vger.kernel.org On Mon, Dec 02, 2013 at 12:47:53PM -0800, Olof Johansson wrote: > On Mon, Dec 2, 2013 at 12:21 PM, Guenter Roeck wrote: > > On Mon, Dec 02, 2013 at 10:14:41AM -0800, Doug Anderson wrote: > >> A good watchdog driver is supposed to report when it was responsible > >> for resetting the system. Implement this for the s3c2410, at least on > >> exynos5250 and exynos5420 where we already have a pointer to the PMU > >> registers to read the information. > >> > >> Signed-off-by: Doug Anderson > >> --- > >> This patch is based atop Leela Krishna's recent series that ends with > >> (ARM: dts: update watchdog device nodes for Exynos5250 and Exynos5420) > >> AKA . > >> > >> drivers/watchdog/s3c2410_wdt.c | 42 +++++++++++++++++++++++++++++++++++++++--- > >> 1 file changed, 39 insertions(+), 3 deletions(-) > >> > >> diff --git a/drivers/watchdog/s3c2410_wdt.c b/drivers/watchdog/s3c2410_wdt.c > >> index 47f4dcf..2c87d37 100644 > >> --- a/drivers/watchdog/s3c2410_wdt.c > >> +++ b/drivers/watchdog/s3c2410_wdt.c > >> @@ -62,9 +62,13 @@ > >> #define CONFIG_S3C2410_WATCHDOG_ATBOOT (0) > >> #define CONFIG_S3C2410_WATCHDOG_DEFAULT_TIME (15) > >> > >> +#define RST_STAT_REG_OFFSET 0x0404 > >> #define WDT_DISABLE_REG_OFFSET 0x0408 > >> #define WDT_MASK_RESET_REG_OFFSET 0x040c > >> #define QUIRK_NEEDS_PMU_CONFIG (1 << 0) > >> +#define QUIRK_HAS_RST_STAT (1 << 1) > >> +#define QUIRKS_NEED_PMUREG (QUIRK_NEEDS_PMU_CONFIG | \ > >> + QUIRK_HAS_RST_STAT) > >> > > I am not really happy about the NEED (both of them, really) here. > > How about HAS instead ? > > Ah, I just commented on these things on our internal review site too > on this patch. I don't even think a quirk is needed -- just use the > presence of a non-0 rst_stat_reg to tell if you need to use regmap. > Agreed; same is true for the QUIRK_NEEDS_PMU_CONFIG related registers as well. Guenter