Linux Watchdog driver development
 help / color / mirror / Atom feed
From: Wim Van Sebroeck <wim@iguana.be>
To: Baruch Siach <baruch@tkos.co.il>
Cc: linux-watchdog@vger.kernel.org, Jamie Iles <jamie@jamieiles.com>
Subject: Re: [PATCH] watchdog: dw_wdt: remove build dependencies
Date: Mon, 30 Dec 2013 12:03:36 +0100	[thread overview]
Message-ID: <20131230110336.GN10136@spo001.leaseweb.com> (raw)
In-Reply-To: <20131230090115.GA3930@tarshish>

Hi Baruch,

> > If this is ARM hardware, then this should have the dependency "depends on 
> > ARM".
> > Only if other architectures start using this watchdog device, then the 
> > "depends on ARM" can go.
> 
> Well, we intend to use this driver on Xtensa platform, does this count?

Xtensa is indeed another Platform, but then I expect the patch to:
1) make this clear in the Kconfig file
2) have a commit-message that also explains this.

> As a general rule wouldn't it be better to have the widest possible build 
> coverage, and encourage arch neutral driver coding?

We try to have as much arch neutral driver encoding (see the Kconfig & Makefile in the drivers/watchdog directory and you will see that we have drivers that are not depending on a specific hardware architecture), but we should not forget that certain hardware is only available in a certain architecture and that it thus does not make any sense to compile kernels with drivers that never will be used. So the general rule still is: use common sense and look at the broader picture.

Kind regards,
Wim.


  reply	other threads:[~2013-12-30 11:03 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-12-30  7:10 [PATCH] watchdog: dw_wdt: remove build dependencies Baruch Siach
2013-12-30  8:37 ` Wim Van Sebroeck
2013-12-30  9:01   ` Baruch Siach
2013-12-30 11:03     ` Wim Van Sebroeck [this message]
2013-12-30 11:30       ` Baruch Siach
2013-12-30 12:08         ` Wim Van Sebroeck
2013-12-30 12:16           ` Baruch Siach

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20131230110336.GN10136@spo001.leaseweb.com \
    --to=wim@iguana.be \
    --cc=baruch@tkos.co.il \
    --cc=jamie@jamieiles.com \
    --cc=linux-watchdog@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox