From mboxrd@z Thu Jan 1 00:00:00 1970 Return-path: Received: from mail-we0-f171.google.com ([74.125.82.171]:64584 "EHLO mail-we0-f171.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932116Ab3L3Tf2 (ORCPT ); Mon, 30 Dec 2013 14:35:28 -0500 Received: by mail-we0-f171.google.com with SMTP id q58so10514583wes.16 for ; Mon, 30 Dec 2013 11:35:26 -0800 (PST) Date: Mon, 30 Dec 2013 19:35:23 +0000 From: Jamie Iles To: Baruch Siach Cc: Wim Van Sebroeck , linux-watchdog@vger.kernel.org, Jamie Iles Subject: Re: [PATCH v2] watchdog: dw_wdt: remove build dependencies Message-ID: <20131230193523.GA3640@maple> References: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: Sender: linux-watchdog-owner@vger.kernel.org List-Id: linux-watchdog@vger.kernel.org Hi Baruch, Looks good, thanks! Acked-by: Jamie Iles Jamie On Mon, Dec 30, 2013 at 02:25:54PM +0200, Baruch Siach wrote: > There is nothing ARM specific in this driver, and we intend to use it on the > Xtensa architecture. Also, clk.h now includes stubs for !CONFIG_HAVE_CLK, so > the driver should build anyway. > > Cc: Jamie Iles > Signed-off-by: Baruch Siach > --- > v2: > Don't mention ARM in the Kconfig help text, and source comment > > Mention in the commit log message that this driver is used on Xtensa > --- > drivers/watchdog/Kconfig | 3 +-- > drivers/watchdog/dw_wdt.c | 2 +- > 2 files changed, 2 insertions(+), 3 deletions(-) > > diff --git a/drivers/watchdog/Kconfig b/drivers/watchdog/Kconfig > index 5be6e91..d3bcad0 100644 > --- a/drivers/watchdog/Kconfig > +++ b/drivers/watchdog/Kconfig > @@ -214,10 +214,9 @@ config SA1100_WATCHDOG > > config DW_WATCHDOG > tristate "Synopsys DesignWare watchdog" > - depends on ARM && HAVE_CLK > help > Say Y here if to include support for the Synopsys DesignWare > - watchdog timer found in many ARM chips. > + watchdog timer found in many chips. > To compile this driver as a module, choose M here: the > module will be called dw_wdt. > > diff --git a/drivers/watchdog/dw_wdt.c b/drivers/watchdog/dw_wdt.c > index a46f5c7..ee4f86b 100644 > --- a/drivers/watchdog/dw_wdt.c > +++ b/drivers/watchdog/dw_wdt.c > @@ -8,7 +8,7 @@ > * 2 of the License, or (at your option) any later version. > * > * This file implements a driver for the Synopsys DesignWare watchdog device > - * in the many ARM subsystems. The watchdog has 16 different timeout periods > + * in the many subsystems. The watchdog has 16 different timeout periods > * and these are a function of the input clock frequency. > * > * The DesignWare watchdog cannot be stopped once it has been started so we > -- > 1.8.5.2 >