linux-watchdog.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Vivek Goyal <vgoyal@redhat.com>
To: One Thousand Gnomes <gnomes@lxorguk.ukuu.org.uk>,
	Dave Young <dyoung@redhat.com>
Cc: wim@iguana.be, dzickus@redhat.com, bhe@redhat.com,
	linux-watchdog@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] watchdog: add a parameter for stop wdt before register
Date: Tue, 14 Jan 2014 11:24:05 -0500	[thread overview]
Message-ID: <20140114162405.GG3096@redhat.com> (raw)
In-Reply-To: <20140114121639.77fe75ec@alan.etchedpixels.co.uk>

On Tue, Jan 14, 2014 at 12:16:39PM +0000, One Thousand Gnomes wrote:
> On Tue, 14 Jan 2014 16:23:23 +0800
> Dave Young <dyoung@redhat.com> wrote:
> 
> > In kdump kernel watchdog could interrupt vmcore capturing because we
> > have no way to disable/stop it while crashing happens.
> 
> Lots of watchdogs cannot be stopped.
> 
> > Add a module parameter stop_before_register so watchdog can be stopped
> > before register in driver loading path. Thus we can try to load the
> > watchdog driver as early as possible in kdump kernel to ensure vmcore
> > capturing.
> 
> If you want to kdump then don't start the watchdog. The goal of the
> watchdog is to make sure the system never gets stuck. Adding conditions
> and special cases simply increases the odds of something bad not
> triggering the watchdog.
> 
> If you have a system that can stop the watchdog then providing no way out
> is not set you can open it and stop it.
> 
> I don't see the need for any kernel change here
> 
> - if it can't be stopped you lost
> - if "nowayout" is set then by design you lost
> - if it can be stopped, you can open and stop it
> 
> Now whether in the !nowayout case the watchdog core should catch whatever
> hooks/notifiers are available and stop any watchdogs it can on a
> kexec/kdump is a more interesting question and probably needs to default
> to not doing so but with the option to force otherwise for debugging work.

Hi All,

I thought this problem was resolved (atleast conceptually) last time
when Don Zickus brought it up.

He mentioned that it was concluded that keep watchdog interval long
enough, say 60 seconds and keep on kicking it fast enough, say every
10-20 seconds. That would ensure that after the crash, there is atleast
60 - 20 = 40 seconds left before watchdog expires. And in that duration
we should try to boot into second kernel load watchdog driver early enough
from initramfs which can start kicking watchdog again.

I am wondering what happened to this idea. Dave, did we try to implement/
experiment with this?

Thanks
Vivek

  reply	other threads:[~2014-01-14 16:24 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-01-14  8:23 [PATCH] watchdog: add a parameter for stop wdt before register Dave Young
2014-01-14  8:26 ` Wim Van Sebroeck
2014-01-14  8:41   ` Dave Young
2014-01-14  9:44     ` Dave Young
2014-01-14 12:16 ` One Thousand Gnomes
2014-01-14 16:24   ` Vivek Goyal [this message]
2014-01-15  1:11     ` Dave Young
2014-01-15 16:46       ` Vivek Goyal
2014-01-16  1:50         ` Dave Young
2014-01-15  0:59   ` Dave Young
2014-01-15 12:15     ` One Thousand Gnomes
2014-01-15 16:55       ` Vivek Goyal
2014-01-16  1:52         ` Dave Young

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20140114162405.GG3096@redhat.com \
    --to=vgoyal@redhat.com \
    --cc=bhe@redhat.com \
    --cc=dyoung@redhat.com \
    --cc=dzickus@redhat.com \
    --cc=gnomes@lxorguk.ukuu.org.uk \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-watchdog@vger.kernel.org \
    --cc=wim@iguana.be \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).