From: Ezequiel Garcia <ezequiel.garcia@free-electrons.com>
To: Andrew Lunn <andrew@lunn.ch>
Cc: Sebastian Hesselbarth <sebastian.hesselbarth@gmail.com>,
linux-arm-kernel@lists.infradead.org,
linux-watchdog@vger.kernel.org, devicetree@vger.kernel.org,
Wim Van Sebroeck <wim@iguana.be>,
Gregory Clement <gregory.clement@free-electrons.com>,
Lior Amsalem <alior@marvell.com>,
Tawfik Bayouk <tawfik@marvell.com>,
Thomas Petazzoni <thomas.petazzoni@free-electrons.com>,
Jason Cooper <jason@lakedaemon.net>,
Jason Gunthorpe <jgunthorpe@obsidianresearch.com>
Subject: Re: [PATCH v2 14/15] watchdog: orion: Allow to build on any Orion platform
Date: Tue, 21 Jan 2014 07:04:35 -0300 [thread overview]
Message-ID: <20140121100434.GC3577@localhost> (raw)
In-Reply-To: <20140121094501.GA13396@lunn.ch>
Hi Andrew, Sebastian:
On Tue, Jan 21, 2014 at 10:45:01AM +0100, Andrew Lunn wrote:
> On Tue, Jan 21, 2014 at 10:41:17AM +0100, Sebastian Hesselbarth wrote:
> > On 01/21/14 10:12, Ezequiel Garcia wrote:
> > >After getting rid of all the mach-specific code, it's now possible
> > >to allow builds in any Orion platform.
> > >
> > >Signed-off-by: Ezequiel Garcia <ezequiel.garcia@free-electrons.com>
> > >---
> > > drivers/watchdog/Kconfig | 2 +-
> > > 1 file changed, 1 insertion(+), 1 deletion(-)
> > >
> > >diff --git a/drivers/watchdog/Kconfig b/drivers/watchdog/Kconfig
> > >index 5be6e91..1689f72 100644
> > >--- a/drivers/watchdog/Kconfig
> > >+++ b/drivers/watchdog/Kconfig
> > >@@ -282,7 +282,7 @@ config DAVINCI_WATCHDOG
> > >
> > > config ORION_WATCHDOG
> > > tristate "Orion watchdog"
> > >- depends on ARCH_ORION5X || ARCH_KIRKWOOD || ARCH_DOVE
> > >+ depends on PLAT_ORION
[..]
> >
> > while above is true now, I tend to rather have ARCH_MVEBU added here.
> > We really want to get rid of both !ARCH_MVEBU and PLAT_ORION and this
> > unnecessarily will make it more complicated.
> >
> > I haven't checked why ARCH_MVEBU at all added PLAT_ORION as dependency,
> > but IIRC it was just because of a missing mbus driver? If it is just
> > this, we should also remove PLAT_ORION from ARCH_MVEBU to have a clean
> > cut between new common arch and existing sub-archs.
>
Hm... not sure why we depend on PLAT_ORION. I'll take a look.
> I took a look at this when moving DT kirkwood into mach-mvebu. There
> is nothing in plat-orion which ARCH_MVEBU needs. So i agree with
> Sebastian, it should be PLAT_ORION || ARCH_MVEBU.
>
OK, will do.
Thanks!
--
Ezequiel García, Free Electrons
Embedded Linux, Kernel and Android Engineering
http://free-electrons.com
--
To unsubscribe from this list: send the line "unsubscribe linux-watchdog" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
next prev parent reply other threads:[~2014-01-21 10:04 UTC|newest]
Thread overview: 64+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-01-21 9:12 [PATCH v2 00/15] Armada 370/XP watchdog support Ezequiel Garcia
2014-01-21 9:12 ` [PATCH v2 01/15] ARM: Introduce atomic MMIO modify Ezequiel Garcia
2014-01-21 9:45 ` Arnd Bergmann
2014-01-21 10:46 ` Ezequiel Garcia
2014-01-21 9:12 ` [PATCH v2 02/15] clocksource: orion: Use atomic access for shared registers Ezequiel Garcia
2014-01-21 9:46 ` Arnd Bergmann
2014-01-21 9:58 ` Sebastian Hesselbarth
2014-01-21 10:54 ` Arnd Bergmann
2014-01-21 11:02 ` Andrew Lunn
2014-01-21 9:57 ` Daniel Lezcano
2014-01-21 10:53 ` Ezequiel Garcia
2014-01-21 9:12 ` [PATCH v2 03/15] watchdog: " Ezequiel Garcia
2014-01-21 9:19 ` Fabio Estevam
2014-01-21 9:42 ` Ezequiel Garcia
2014-01-21 9:54 ` Arnd Bergmann
2014-01-21 10:13 ` Andrew Lunn
2014-01-21 9:12 ` [PATCH v2 04/15] watchdog: orion: Handle IRQ Ezequiel Garcia
2014-01-21 9:12 ` [PATCH v2 05/15] watchdog: orion: Make RSTOUT register a separate resource Ezequiel Garcia
2014-01-21 23:33 ` Jason Gunthorpe
2014-01-22 9:48 ` Arnd Bergmann
2014-01-22 16:21 ` Ezequiel Garcia
2014-01-22 18:01 ` Ezequiel Garcia
2014-01-22 18:14 ` Jason Gunthorpe
2014-01-22 18:21 ` Arnd Bergmann
2014-01-22 18:29 ` Ezequiel Garcia
2014-01-21 9:12 ` [PATCH v2 06/15] watchdog: orion: Remove unneeded BRIDGE_CAUSE clear Ezequiel Garcia
2014-01-21 23:35 ` Jason Gunthorpe
2014-01-22 16:49 ` Ezequiel Garcia
2014-01-22 17:34 ` Jason Gunthorpe
2014-01-22 17:45 ` Ezequiel Garcia
2014-01-22 17:50 ` Jason Gunthorpe
2014-01-22 18:03 ` Ezequiel Garcia
2014-01-22 20:31 ` Sebastian Hesselbarth
2014-01-22 20:52 ` Jason Gunthorpe
2014-01-22 22:12 ` Ezequiel Garcia
2014-01-22 22:31 ` Jason Gunthorpe
2014-01-22 22:56 ` Ezequiel Garcia
2014-01-23 0:03 ` Sebastian Hesselbarth
2014-01-23 0:19 ` Jason Gunthorpe
2014-01-23 0:35 ` Sebastian Hesselbarth
2014-01-23 12:04 ` Ezequiel Garcia
2014-01-22 23:49 ` Sebastian Hesselbarth
2014-01-23 11:10 ` Ezequiel Garcia
2014-01-23 11:54 ` Ezequiel Garcia
2014-01-23 21:15 ` Sebastian Hesselbarth
2014-01-21 9:12 ` [PATCH v2 07/15] watchdog: orion: Introduce an orion_watchdog device structure Ezequiel Garcia
2014-01-21 9:12 ` [PATCH v2 08/15] watchdog: orion: Introduce per-compatible of_device_id data Ezequiel Garcia
2014-01-21 9:12 ` [PATCH v2 09/15] watchdog: orion: Add per-compatible clock initialization Ezequiel Garcia
2014-01-21 9:18 ` Fabio Estevam
2014-01-21 9:43 ` Ezequiel Garcia
2014-01-21 9:12 ` [PATCH v2 10/15] watchdog: orion: Add per-compatible watchdog start implementation Ezequiel Garcia
2014-01-21 9:12 ` [PATCH v2 11/15] watchdog: orion: Add support for Armada 370 and Armada XP SoC Ezequiel Garcia
2014-01-21 9:12 ` [PATCH v2 12/15] ARM: mvebu: Enable Armada 370/XP watchdog in the devicetree Ezequiel Garcia
2014-01-21 9:12 ` [PATCH v2 13/15] ARM: kirkwood: Add RSTOUT 'reg' entry to devicetree Ezequiel Garcia
2014-01-21 9:12 ` [PATCH v2 14/15] watchdog: orion: Allow to build on any Orion platform Ezequiel Garcia
2014-01-21 9:41 ` Sebastian Hesselbarth
2014-01-21 9:45 ` Andrew Lunn
2014-01-21 10:04 ` Ezequiel Garcia [this message]
2014-01-21 11:06 ` Removing PLAT_ORION dependency from ARCH_MVEBU (Was Re: [PATCH v2 14/15] watchdog: orion: Allow to build on any Orion platform) Ezequiel Garcia
2014-01-21 11:44 ` Sebastian Hesselbarth
2014-01-21 9:12 ` [PATCH v2 15/15] ARM: mvebu: Enable watchdog support in defconfig Ezequiel Garcia
2014-01-21 12:47 ` Jason Cooper
2014-01-21 12:53 ` Andrew Lunn
2014-01-21 12:57 ` Jason Cooper
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140121100434.GC3577@localhost \
--to=ezequiel.garcia@free-electrons.com \
--cc=alior@marvell.com \
--cc=andrew@lunn.ch \
--cc=devicetree@vger.kernel.org \
--cc=gregory.clement@free-electrons.com \
--cc=jason@lakedaemon.net \
--cc=jgunthorpe@obsidianresearch.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-watchdog@vger.kernel.org \
--cc=sebastian.hesselbarth@gmail.com \
--cc=tawfik@marvell.com \
--cc=thomas.petazzoni@free-electrons.com \
--cc=wim@iguana.be \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).