From: Guenter Roeck <linux@roeck-us.net>
To: Alexander Shiyan <shc_work@mail.ru>
Cc: linux-watchdog@vger.kernel.org, Wim Van Sebroeck <wim@iguana.be>
Subject: Re: [PATCH] watchdog: intel_scu_watchdog: Remove unused variable
Date: Sat, 15 Feb 2014 09:46:08 -0800 [thread overview]
Message-ID: <20140215174608.GD19001@roeck-us.net> (raw)
In-Reply-To: <1392456138-30003-1-git-send-email-shc_work@mail.ru>
On Sat, Feb 15, 2014 at 01:22:18PM +0400, Alexander Shiyan wrote:
> Variable "hw_pre_value" is not used anywhere in the
> function intel_scu_set_heartbeat().
> This patch removes this variable.
>
> Signed-off-by: Alexander Shiyan <shc_work@mail.ru>
Reviewed-by: Guenter Roeck <linux@roeck-us.net>
> ---
> drivers/watchdog/intel_scu_watchdog.c | 4 +---
> 1 file changed, 1 insertion(+), 3 deletions(-)
>
> diff --git a/drivers/watchdog/intel_scu_watchdog.c b/drivers/watchdog/intel_scu_watchdog.c
> index e13e65e..0caab62 100644
> --- a/drivers/watchdog/intel_scu_watchdog.c
> +++ b/drivers/watchdog/intel_scu_watchdog.c
> @@ -211,7 +211,6 @@ static int intel_scu_set_heartbeat(u32 t)
> int ipc_ret;
> int retry_count;
> u32 soft_value;
> - u32 hw_pre_value;
> u32 hw_value;
>
> watchdog_device.timer_set = t;
> @@ -273,8 +272,7 @@ static int intel_scu_set_heartbeat(u32 t)
> watchdog_device.timer_load_count_addr);
>
> /* read count value before starting timer */
> - hw_pre_value = ioread32(watchdog_device.timer_load_count_addr);
> - hw_pre_value = hw_pre_value & 0xFFFF0000;
> + ioread32(watchdog_device.timer_load_count_addr);
>
> /* Start the timer */
> iowrite32(0x00000003, watchdog_device.timer_control_addr);
> --
> 1.8.3.2
>
> --
> To unsubscribe from this list: send the line "unsubscribe linux-watchdog" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html
>
next prev parent reply other threads:[~2014-02-15 17:46 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-02-15 9:22 [PATCH] watchdog: intel_scu_watchdog: Remove unused variable Alexander Shiyan
2014-02-15 17:46 ` Guenter Roeck [this message]
2014-02-24 19:58 ` Wim Van Sebroeck
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140215174608.GD19001@roeck-us.net \
--to=linux@roeck-us.net \
--cc=linux-watchdog@vger.kernel.org \
--cc=shc_work@mail.ru \
--cc=wim@iguana.be \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox