From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Date: Wed, 9 Apr 2014 13:41:21 +0100 From: One Thousand Gnomes To: Guenter Roeck Cc: David Cohen , wim@iguana.be, tglx@linutronix.de, mingo@redhat.com, hpa@zytor.com, x86@kernel.org, linux-kernel@vger.kernel.org, linux-watchdog@vger.kernel.org, Eric Ernst Subject: Re: [PATCH 1/2] watchdog: add Intel MID watchdog driver support Message-ID: <20140409134121.7ce4e7a4@alan.etchedpixels.co.uk> In-Reply-To: <5344919E.9030708@roeck-us.net> References: <1396990744-10695-1-git-send-email-david.a.cohen@linux.intel.com> <1396990744-10695-2-git-send-email-david.a.cohen@linux.intel.com> <5344919E.9030708@roeck-us.net> Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit List-ID: On Tue, 08 Apr 2014 17:17:34 -0700 Guenter Roeck wrote: > On 04/08/2014 01:59 PM, David Cohen wrote: > > Add initial Intel MID watchdog driver support. > > > > This driver is an initial implementation of generic Intel MID watchdog > > driver. Currently it supports Intel Merrifield platform. > > How does this compare with the existing SCU watchdog driver > (intel_scu_watchdog) ? The watchdog IPC message (0xf8) seems > to be the same, so there must be at least some overlap. > Would it be possible to have just one watchdog driver > serving the different SCU based devices ? There are enough differences that we'd end up with one spaghetti driver full of conditionals rather than two simple clean drivers. Alan