Re: [PATCH 2/2] x86: intel-mid: add watchdog platform code for Merrifield

[David Cohen <david.a.cohen@linux.intel.com>]

On Wed, Apr 09, 2014 at 01:42:23PM +0100, One Thousand Gnomes wrote:
> On Tue,  8 Apr 2014 13:59:04 -0700
> David Cohen <david.a.cohen@linux.intel.com> wrote:
> 
> > This patch adds platform code for Intel Merrifield.
> > Since the watchdog is not part of SFI table, we have no other option but
> > to manually register watchdog's platform device (argh!).
> 
> Before going too far down that path have you considered compiling in a
> devicetree instead ?

This is the only device missing from SFI table I am aware of.
The original implementation is to register the watchdog without a
device/driver match. i.e. directly from the init call. Then the init
call has a conditional check if it's Merrifield with
intel_mid_identify_cpu() to avoid it being registered in !Merrifield
platforms. But I want to lock this intel_mid_identify_cpu() inside
intel_mid platform code, since it's too ugly to stay inside drivers.

If we figure out there's more devices missing from SFI table, then we
could revisit here and consider another approach.

Br, David

> 
> Alan