From: Guenter Roeck <linux@roeck-us.net>
To: David Cohen <david.a.cohen@linux.intel.com>
Cc: wim@iguana.be, tglx@linutronix.de, mingo@redhat.com,
hpa@zytor.com, x86@kernel.org, linux-kernel@vger.kernel.org,
linux-watchdog@vger.kernel.org, gnomes@lxorguk.ukuu.org.uk
Subject: Re: [PATCH 2/2] x86: intel-mid: add watchdog platform code for Merrifield
Date: Thu, 10 Apr 2014 12:15:23 -0700 [thread overview]
Message-ID: <20140410191523.GA6206@roeck-us.net> (raw)
In-Reply-To: <1396990744-10695-3-git-send-email-david.a.cohen@linux.intel.com>
On Tue, Apr 08, 2014 at 01:59:04PM -0700, David Cohen wrote:
> This patch adds platform code for Intel Merrifield.
> Since the watchdog is not part of SFI table, we have no other option but
> to manually register watchdog's platform device (argh!).
>
> Signed-off-by: David Cohen <david.a.cohen@linux.intel.com>
> ---
Does it really make sense to have this as separate patch ?
It is quite common for watchdog (and many other) drivers to
register the driver and instantiate the device. I think it
would be better and more consistent to have both patches
merged into one.
Thanks,
Guenter
next prev parent reply other threads:[~2014-04-10 19:15 UTC|newest]
Thread overview: 44+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-04-08 20:59 [PATCH 0/2] Initial implementation of Intel MID watchdog driver David Cohen
2014-04-08 20:59 ` [PATCH 1/2] watchdog: add Intel MID watchdog driver support David Cohen
2014-04-08 23:56 ` Randy Dunlap
2014-04-09 17:48 ` David Cohen
2014-04-10 13:51 ` Guenter Roeck
2014-04-10 18:24 ` David Cohen
2014-04-09 0:17 ` Guenter Roeck
2014-04-09 12:41 ` One Thousand Gnomes
2014-04-08 20:59 ` [PATCH 2/2] x86: intel-mid: add watchdog platform code for Merrifield David Cohen
2014-04-09 12:42 ` One Thousand Gnomes
2014-04-09 13:49 ` Alexander Stein
2014-04-09 13:58 ` One Thousand Gnomes
2014-04-09 14:03 ` Alexander Stein
2014-04-09 15:18 ` Guenter Roeck
2014-04-09 16:10 ` Alexander Stein
2014-04-09 17:15 ` Guenter Roeck
2014-04-10 11:08 ` One Thousand Gnomes
2014-04-09 18:00 ` David Cohen
2014-04-10 19:15 ` Guenter Roeck [this message]
2014-04-10 19:30 ` David Cohen
2014-04-10 20:35 ` Guenter Roeck
2014-04-10 21:23 ` David Cohen
2014-04-10 22:51 ` Guenter Roeck
2014-04-11 20:50 ` [PATCH v2 0/2] Initial implementation of Intel MID watchdog driver David Cohen
2014-04-11 20:50 ` [PATCH v2 1/2] watchdog: add Intel MID watchdog driver support David Cohen
2014-04-11 20:50 ` [PATCH v2 2/2] x86: intel-mid: add watchdog platform code for Merrifield David Cohen
2014-04-15 18:41 ` [PATCH v3 0/2] Initial implementation of Intel MID watchdog driver David Cohen
2014-04-15 18:41 ` [PATCH v3 1/2] watchdog: add Intel MID watchdog driver support David Cohen
2014-04-15 19:01 ` Guenter Roeck
2014-04-15 19:24 ` David Cohen
2014-04-15 18:41 ` [PATCH v3 2/2] x86: intel-mid: add watchdog platform code for Merrifield David Cohen
2014-04-15 19:09 ` Guenter Roeck
2014-04-15 19:30 ` David Cohen
2014-04-15 20:06 ` [PATCH v4 0/2] Initial implementation of Intel MID watchdog driver David Cohen
2014-04-15 20:06 ` [PATCH v4 1/2] watchdog: add Intel MID watchdog driver support David Cohen
2014-04-16 0:13 ` Guenter Roeck
2014-04-15 20:06 ` [PATCH v4 2/2] x86: intel-mid: add watchdog platform code for Merrifield David Cohen
2014-04-15 20:09 ` David Cohen
2014-04-15 21:13 ` Guenter Roeck
2014-04-15 21:17 ` David Cohen
2014-04-15 21:35 ` Guenter Roeck
2014-04-15 21:39 ` David Cohen
2014-04-15 22:20 ` [PATCH v4.1 " David Cohen
2014-04-16 0:16 ` Guenter Roeck
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140410191523.GA6206@roeck-us.net \
--to=linux@roeck-us.net \
--cc=david.a.cohen@linux.intel.com \
--cc=gnomes@lxorguk.ukuu.org.uk \
--cc=hpa@zytor.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-watchdog@vger.kernel.org \
--cc=mingo@redhat.com \
--cc=tglx@linutronix.de \
--cc=wim@iguana.be \
--cc=x86@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).