From: Guenter Roeck <linux@roeck-us.net>
To: gundberg <per.gundberg@icomera.com>
Cc: wim@iguana.be, linux-watchdog@vger.kernel.org,
linux-kernel@vger.kernel.org,
Michael Brunner <michael.brunner@kontron.com>
Subject: Re: [PATCH] watchdog: kempld-wdt: Use the correct value when configuring the prescaler with the watchdog
Date: Thu, 24 Apr 2014 08:15:40 -0700 [thread overview]
Message-ID: <20140424151540.GA6767@roeck-us.net> (raw)
In-Reply-To: <5359165F.5040102@icomera.com>
On Thu, Apr 24, 2014 at 03:49:19PM +0200, gundberg wrote:
> Use the prescaler index, rather than its value, to configure the watchdog.
> This will prevent a mismatch with the prescaler used to calculate the cycles.
>
> Signed-off-by: Per Gundberg <per.gundberg@icomera.com>
Good catch. Looks correct to me. Michael, any comments ?
Reviewed-by: Guenter Roeck <linux@roeck-us.net>
> ---
> drivers/watchdog/kempld_wdt.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> --- src/drivers/watchdog/kempld_wdt.c.orig 2014-04-24 07:32:08.463745055 +0000
> +++ src/drivers/watchdog/kempld_wdt.c 2014-04-24 07:34:09.839739808 +0000
> @@ -163,7 +163,7 @@ static int kempld_wdt_set_stage_timeout(
> kempld_get_mutex(pld);
> stage_cfg = kempld_read8(pld, KEMPLD_WDT_STAGE_CFG(stage->id));
> stage_cfg &= ~STAGE_CFG_PRESCALER_MASK;
> - stage_cfg |= STAGE_CFG_SET_PRESCALER(prescaler);
> + stage_cfg |= STAGE_CFG_SET_PRESCALER(PRESCALER_21);
> kempld_write8(pld, KEMPLD_WDT_STAGE_CFG(stage->id), stage_cfg);
> kempld_write32(pld, KEMPLD_WDT_STAGE_TIMEOUT(stage->id),
> stage_timeout);
> --
> To unsubscribe from this list: send the line "unsubscribe linux-watchdog" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html
>
next prev parent reply other threads:[~2014-04-24 15:15 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-04-24 13:49 [PATCH] watchdog: kempld-wdt: Use the correct value when configuring the prescaler with the watchdog gundberg
2014-04-24 15:15 ` Guenter Roeck [this message]
2014-05-07 20:19 ` Michael Brunner
[not found] <CAKUdnSzO2ixCOvvxAwz3duXsPEpExVND7VA_DVPAYpwQGTwYdQ@mail.gmail.com>
2014-05-26 18:59 ` Wim Van Sebroeck
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140424151540.GA6767@roeck-us.net \
--to=linux@roeck-us.net \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-watchdog@vger.kernel.org \
--cc=michael.brunner@kontron.com \
--cc=per.gundberg@icomera.com \
--cc=wim@iguana.be \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).