From: Maxime Ripard <maxime.ripard@free-electrons.com>
To: "Emilio López" <emilio@elopez.com.ar>
Cc: Guenter Roeck <linux@roeck-us.net>,
wim@iguana.be, carlo.caione@gmail.com,
linux-watchdog@vger.kernel.org,
linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH] watchdog: sunxi: Fix compilation with C=2
Date: Thu, 15 May 2014 10:52:14 +0200 [thread overview]
Message-ID: <20140515085214.GP29258@lukather> (raw)
In-Reply-To: <536FD3B3.3030100@elopez.com.ar>
[-- Attachment #1: Type: text/plain, Size: 835 bytes --]
On Sun, May 11, 2014 at 04:46:59PM -0300, Emilio López wrote:
> El 04/04/14 15:02, Guenter Roeck escribió:
> >On 04/04/2014 10:24 AM, Emilio López wrote:
> >>When compiling sunxi_defconfig while using C=2, the following error
> >>causes the compilation to fail:
> >>
> >> drivers/watchdog/sunxi_wdt.c:60:15: error: constant 0b0001 is not
> >>a valid number
> >>
> >>Fix it by using hex notation instead of the non-standard binary one
> >>
> >>Signed-off-by: Emilio López <emilio@elopez.com.ar>
> >
> >Reviewed-by: Guenter Roeck <linux@roeck-us.net>
> >
>
> Wim, Maxime, any comments on this?
I'm fine with this. Wim? Do you want to take this patch, or can we
have an Acked-by?
Thanks,
Maxime
--
Maxime Ripard, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com
[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 819 bytes --]
next prev parent reply other threads:[~2014-05-15 8:55 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-04-04 17:24 [PATCH] watchdog: sunxi: Fix compilation with C=2 Emilio López
2014-04-04 17:35 ` Guenter Roeck
2014-04-04 17:57 ` Emilio López
2014-04-04 18:01 ` Guenter Roeck
2014-04-04 18:02 ` Guenter Roeck
2014-05-11 19:46 ` Emilio López
2014-05-15 8:52 ` Maxime Ripard [this message]
2014-05-26 18:50 ` Wim Van Sebroeck
2014-05-26 18:51 ` Wim Van Sebroeck
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140515085214.GP29258@lukather \
--to=maxime.ripard@free-electrons.com \
--cc=carlo.caione@gmail.com \
--cc=emilio@elopez.com.ar \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-watchdog@vger.kernel.org \
--cc=linux@roeck-us.net \
--cc=wim@iguana.be \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox