From: Guenter Roeck <linux@roeck-us.net>
To: Pranith Kumar <bobby.prani@gmail.com>
Cc: Wim Van Sebroeck <wim@iguana.be>,
"open list:WATCHDOG DEVICE D..." <linux-watchdog@vger.kernel.org>,
open list <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH v2] powerpc: booke_wdt: Fix build error as a module
Date: Wed, 20 Aug 2014 13:10:51 -0700 [thread overview]
Message-ID: <20140820201051.GA1745@roeck-us.net> (raw)
In-Reply-To: <1408562806-22950-1-git-send-email-bobby.prani@gmail.com>
On Wed, Aug 20, 2014 at 03:26:46PM -0400, Pranith Kumar wrote:
> Building booke_wdt fails when trying to build as a module as there is no
> early_param() in module. Fix by using module_param() instead of early_param().
>
> Signed-off-by: Pranith Kumar <bobby.prani@gmail.com>
> CC: Guenter Roeck <linux@roeck-us.net>
Looks good as far as I can see. One question though:
> +MODULE_ALIAS("booke_wdt");
Is this necessary ? If yes, shouldn't it be a separate patch to be applied
to -stable ?
Thanks,
Guenter
next prev parent reply other threads:[~2014-08-20 20:10 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-08-20 19:26 [PATCH v2] powerpc: booke_wdt: Fix build error as a module Pranith Kumar
2014-08-20 20:10 ` Guenter Roeck [this message]
2014-08-20 20:19 ` Pranith Kumar
2014-08-20 21:31 ` Guenter Roeck
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140820201051.GA1745@roeck-us.net \
--to=linux@roeck-us.net \
--cc=bobby.prani@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-watchdog@vger.kernel.org \
--cc=wim@iguana.be \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).