From mboxrd@z Thu Jan 1 00:00:00 1970 Return-path: Received: from mail-ie0-f170.google.com ([209.85.223.170]:59582 "EHLO mail-ie0-f170.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754493AbaHUNZ3 (ORCPT ); Thu, 21 Aug 2014 09:25:29 -0400 Received: by mail-ie0-f170.google.com with SMTP id rl12so4704861iec.1 for ; Thu, 21 Aug 2014 06:25:28 -0700 (PDT) Date: Thu, 21 Aug 2014 14:25:22 +0100 From: Lee Jones To: Andreas Werner Cc: linux-kernel@vger.kernel.org, sameo@linux.intel.com, wim@iguana.be, linux-watchdog@vger.kernel.org, cooloney@gmail.com, rpurdie@rpsys.net, linux-leds@vger.kernel.org, jdelvare@suse.de, linux@roeck-us.net, lm-sensors@lm-sensors.org Subject: Re: [PATCH v4 1/4] drivers/mfd/menf21bmc: introduce MEN 14F021P00 BMC MFD Core driver Message-ID: <20140821132522.GI4266@lee--X1> References: <20140821113046.GZ4266@lee--X1> <20140821135707.GA16867@awelinux> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: QUOTED-PRINTABLE In-Reply-To: <20140821135707.GA16867@awelinux> Sender: linux-watchdog-owner@vger.kernel.org List-Id: linux-watchdog@vger.kernel.org On Thu, 21 Aug 2014, Andreas Werner wrote: > On Thu, Aug 21, 2014 at 12:30:46PM +0100, Lee Jones wrote: > > On Wed, 13 Aug 2014, Andreas Werner wrote: > > > The MEN 14F021P00 Board Management Controller provides an > > > I2C interface to the host to access the feature implemented in th= e BMC. > > > The BMC is a PIC Microntroller assembled on CPCI Card from MEN Mi= kroelektronik > > > and on a few Box/Display Computer. > > >=20 > > > Added MFD Core driver, supporting the I2C communication to the de= vice. > > >=20 > > > The MFD driver currently supports the following features: > > > - Watchdog > > > - LEDs > > > - Hwmon (voltage monitoring) > > >=20 > > > Signed-off-by: Andreas Werner > > > --- > > > drivers/mfd/Kconfig | 12 +++++ > > > drivers/mfd/Makefile | 1 + > > > drivers/mfd/menf21bmc.c | 132 ++++++++++++++++++++++++++++++++++= ++++++++++++++ > > > 3 files changed, 145 insertions(+) > > > create mode 100644 drivers/mfd/menf21bmc.c > > >=20 > > > diff --git a/drivers/mfd/Kconfig b/drivers/mfd/Kconfig > > > index b8d9ca0..bf155b9 100644 > > > --- a/drivers/mfd/Kconfig > > > +++ b/drivers/mfd/Kconfig > > > @@ -453,6 +453,18 @@ config MFD_MAX8998 > > > additional drivers must be enabled in order to use the functi= onality > > > of the device. > > > =20 > > > +config MFD_MENF21BMC > > > + tristate "MEN 14F021P00 Board Management Controller Support" > > > + depends on I2C=3Dy > >=20 > > Why must I2C be built-in? >=20 > Sorry my mistake, I2C must not be built in. >=20 > >=20 > > > + select MFD_CORE > > > + help > > > + Say yes here to add support for the MEN 14F021P00 BMC > > > + which is a Board Management Controller connected to the I2C b= us. > > > + The device supports multiple sub-devices like LED, HWMON and= WDT. > > > + This driver provides common support for accessing the devices= ; > > > + additional drivers must be enabled in order to use the > > > + functionality of the BMC device. > > > + > >=20 > > Apart from that the patch looks good to me. > >=20 > > I'm assuming this can go in via the MFD tree by itself? >=20 > Yes why not. > Do you want to have a single patch for the MFD or > is it better to wait for the other Subsystem maintainer that I=20 > can resend a patch v5? When you resent, apply my Ack and I'll pick it up when the other Maintainers are happy. > >=20 > > Acked-by: Lee Jones > >=20 --=20 Lee Jones Linaro STMicroelectronics Landing Team Lead Linaro.org =E2=94=82 Open source software for ARM SoCs =46ollow Linaro: Facebook | Twitter | Blog -- To unsubscribe from this list: send the line "unsubscribe linux-watchdo= g" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html