From: Shawn Guo <shawn.guo@freescale.com>
To: Lu Jingchang-B35083 <jingchang.lu@freescale.com>
Cc: Guenter Roeck <linux@roeck-us.net>,
"wim@iguana.be" <wim@iguana.be>, "arnd@arndb.de" <arnd@arndb.de>,
"linux-watchdog@vger.kernel.org" <linux-watchdog@vger.kernel.org>,
"linux-arm-kernel@lists.infradead.org"
<linux-arm-kernel@lists.infradead.org>
Subject: Re: [PATCH] watchdog: imx2_wdt: add restart handler support
Date: Fri, 12 Sep 2014 15:45:12 +0800 [thread overview]
Message-ID: <20140912074510.GJ18566@dragon> (raw)
In-Reply-To: <299ae9bd88c049ea833e964e4b5f54a0@BL2PR03MB467.namprd03.prod.outlook.com>
On Fri, Sep 12, 2014 at 10:42:10AM +0800, Lu Jingchang-B35083 wrote:
> >> @@ -77,6 +81,31 @@ static const struct watchdog_info imx2_wdt_info = {
> >> .options = WDIOF_KEEPALIVEPING | WDIOF_SETTIMEOUT | WDIOF_MAGICCLOSE,
> >> };
> >>
> >> +static int imx2_restart_handler(struct notifier_block *this, unsigned
> >long mode,
> >> + void *cmd)
> >> +{
> >> + unsigned int wcr_enable = IMX2_WDT_WCR_WDE;
> >
> >In the original code this value is conditional depending on cpu_is_mx1().
> >Are there any implications for this reset mechanism ? Does mx1 have a
> >different watchdog driver ?
> >
> Hi, Shawn, is this driver also used by the mx1 SoC?
> The imx2_wdt.c says it is for IMX2 and later processors, so when moving the
> restart function, I removed the cpu_is_mx1() condition determination, Thanks.
I think the driver only works for i.MX2 and later ones.
Shawn
prev parent reply other threads:[~2014-09-12 8:01 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-09-11 7:47 [PATCH] watchdog: imx2_wdt: add restart handler support Jingchang Lu
2014-09-11 15:55 ` Guenter Roeck
2014-09-12 2:42 ` Jingchang Lu
2014-09-12 2:49 ` Guenter Roeck
2014-09-12 3:12 ` Jingchang Lu
2014-09-12 7:45 ` Shawn Guo [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140912074510.GJ18566@dragon \
--to=shawn.guo@freescale.com \
--cc=arnd@arndb.de \
--cc=jingchang.lu@freescale.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-watchdog@vger.kernel.org \
--cc=linux@roeck-us.net \
--cc=wim@iguana.be \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox