Re: [PATCH 4/4] ARM: dts: Enable the reference clock for timer and watchdog on Armada 375 SoC

Thomas Petazzoni
2014-10-22T13:55:14Z

Dear Ezequiel Garcia,

On Wed, 22 Oct 2014 10:34:44 -0300, Ezequiel Garcia wrote:

> - clocks = <&coreclk 0>;
> + clocks = <&refclk>;
> + clock-names = "fixed";

Why not do like we do on Armada XP, and actually represent the
hardware, by showing that it takes two clocks as input:

timer@20300 {
compatible = "marvell,armada-xp-timer";
clocks = <&coreclk 2>, <&refclk>;
clock-names = "nbclk", "fixed";
};

> watchdog@20300 {
> compatible = "marvell,armada-375-wdt";
> reg = <0x20300 0x34>, <0x20704 0x4>, <0x18254 0x4>;
> - clocks = <&coreclk 0>;
> + clocks = <&refclk>;
> + clock-names = "fixed";
> };

Ditto.

Thomas
--
Thomas Petazzoni, CTO, Free Electrons