From mboxrd@z Thu Jan 1 00:00:00 1970 Return-path: Received: from down.free-electrons.com ([37.187.137.238]:52732 "EHLO mail.free-electrons.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1751260AbaJVNwB (ORCPT ); Wed, 22 Oct 2014 09:52:01 -0400 Date: Wed, 22 Oct 2014 15:51:58 +0200 From: Thomas Petazzoni To: Ezequiel Garcia Cc: Jason Cooper , Daniel Lezcano , Thomas Gleixner , Wim Van Sebroeck , , , Nadav Haklai , Tawfik Bayouk , Lior Amsalem , Gregory Clement Subject: Re: [PATCH 2/4] watchdog: orion: Use the reference clock on Armada 375 SoC Message-ID: <20141022155158.47f3b637@free-electrons.com> In-Reply-To: <1413984884-20273-3-git-send-email-ezequiel.garcia@free-electrons.com> References: <1413984884-20273-1-git-send-email-ezequiel.garcia@free-electrons.com> <1413984884-20273-3-git-send-email-ezequiel.garcia@free-electrons.com> MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Sender: linux-watchdog-owner@vger.kernel.org List-Id: linux-watchdog@vger.kernel.org Dear Ezequiel Garcia, On Wed, 22 Oct 2014 10:34:42 -0300, Ezequiel Garcia wrote: > The 25 MHz reference clock has better stability so its use is preferred over the > core clock. Changes the Armada 375 clock initialization to use this reference > clock. To ensure the driver is compatible with an old devicetree, also provide > a fallback path which will silently return to the previous behavior. > > Signed-off-by: Ezequiel Garcia > --- > drivers/watchdog/orion_wdt.c | 40 +++++++++++++++++++++++++++++++++++++++- > 1 file changed, 39 insertions(+), 1 deletion(-) The Armada 375 case should be similar to the Armada XP case, so can't we use the existing armadaxp_wdt_clock_init() function ? Thanks, Thomas -- Thomas Petazzoni, CTO, Free Electrons Embedded Linux, Kernel and Android engineering http://free-electrons.com