Re: [PATCH] watchdog: at91rm9200: allow building when using device tree

Alexandre Belloni
2014-10-30T15:17:56Z

On 30/10/2014 at 15:43:43 +0100, Arnd Bergmann wrote :
> On Thursday 30 October 2014 15:36:24 Boris Brezillon wrote:
> > On Thu, 30 Oct 2014 15:15:34 +0100
> > Alexandre Belloni <alexandre.belloni@free-electrons.com> wrote:
> >
> > > When building with device tree, ARCH_AT91RM9200 may not be selected. Allow
> > > building that driver by also depending on ARCH_AT91.
> > >
> > > Signed-off-by: Alexandre Belloni <alexandre.belloni@free-electrons.com>
> >
> > Acked-by: Boris Brezillon <boris.brezillon@free-electrons.com>
> >
>
> Doesn't this reintroduce the bug fixed by commit 09549cd0172 ("watchdog:
> Revert the AT91RM9200_WATCHDOG dependency")?
>
> At least in 3.18-rc2, the driver still uses at91_st_write/at91_st_read.
>

Hum, right, then we have no better way to express that than depends on
SOC_AT91RM9200, would that be acceptable ?

--
Alexandre Belloni, Free Electrons
Embedded Linux, Kernel and Android engineering