From mboxrd@z Thu Jan 1 00:00:00 1970 Return-path: Received: from ns1.pc-advies.be ([83.149.101.17]:42591 "EHLO spo001.leaseweb.nl" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1753632AbaKYNeM (ORCPT ); Tue, 25 Nov 2014 08:34:12 -0500 Date: Tue, 25 Nov 2014 14:34:09 +0100 From: Wim Van Sebroeck To: Daniel Lezcano Cc: Ezequiel Garcia , linux-watchdog@vger.kernel.org, linux-arm-kernel@lists.infradead.org, Jason Cooper , Gregory Clement , Thomas Petazzoni , Tawfik Bayouk , Lior Amsalem , Andrew Lunn , Nadav Haklai Subject: Re: [PATCH v3 0/3] Make Armada 375 use the reference clock when possible Message-ID: <20141125133409.GC19785@spo001.leaseweb.nl> References: <1415107293-19258-1-git-send-email-ezequiel.garcia@free-electrons.com> <546C6226.5000900@linaro.org> <20141119104535.GB8973@spo001.leaseweb.nl> <5472F48E.40802@linaro.org> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: QUOTED-PRINTABLE In-Reply-To: <5472F48E.40802@linaro.org> Sender: linux-watchdog-owner@vger.kernel.org List-Id: linux-watchdog@vger.kernel.org Hi Daniel, I'm OK with the patchset. You can add my Acked-by. Kind regards, Wim. > On 11/19/2014 11:45 AM, Wim Van Sebroeck wrote: > >Hi Daniel, > > > >I'll review before the weekend and will let you know something. > >But everything through one tree is fine by me. >=20 > Hi Wim, >=20 > did you have time to review this patchset ? I would like to send my P= R=20 > for tglx as soon as possible. >=20 > Thanks > -- Daniel >=20 > > > >Kind regards, > >Wim. > > > >>On 11/04/2014 02:21 PM, Ezequiel Garcia wrote: > >>>Hi Daniel, Wim: > >>> > >>>Seems we are ready to merge these, unless some objection raises. D= o you > >>>think > >>>you can take the patches through your trees? > >> > >>Hi Wim, > >> > >>I can take through my tree the entire patchset if you want but I ne= ed > >>your blessing for the watchdog part. > >> > >>Thanks > >> -- Daniel > >> > >>>Changes from v2: > >>> > >>> * Fix messed up empty lines, as suggested by Thomas Petazzoni. > >>> > >>>Changes from v1: > >>> > >>> * Make the A375 timer and watchdog devicetree binding match the= =20 > >>> hardware > >>> and require the two available clocks: core and reference cloc= k. > >>> > >>>This series adds support for the 25 MHz reference clock available = on > >>>Armada 375 SoC to be used on the timer and watchdog drivers. It is > >>>similar to the one present in Armada XP SoC. > >>> > >>>Given we initially had access to only a very early SoC revision (A= 375 Z1) > >>>and due to a hardware issue, the timer and watchdog support was=20 > >>>originally > >>>submitted to use the core clock. > >>> > >>>Now that the A0 SoC revision is out, we can fix this and use the=20 > >>>reference > >>>clock. The reason for this change is that the core clock is subjec= t to=20 > >>>the > >>>SSCG (Spread Spectrum Clock Generator), so boards where SSCG is en= abled > >>>exhibit a very large timer drift. > >>> > >>>Notice that this change will produce unpleseant results on A375 Z1= , given > >>>the > >>>reference 25 MHz clock doesn't work properly on that SoC revision. > >>> > >>>But since the Z1 revision is not supported by the recently submitt= ed A375 > >>>network driver (mvpp2), and therefore nobody is expected to run ma= inline > >>>(if there are users at all of this early revision), the support wi= ll be > >>>dropped entirely in a near future. > >>> > >>>To prevent any compatibility issues when booting with an older=20 > >>>devicetree, > >>>this series provides proper fall backs in each case. > >>> > >>>The series applies on v3.18-rc2. > >>> > >>>Ezequiel Garcia (3): > >>> clocksource: armada-370-xp: Add missing clock enable > >>> watchdog: orion: Use the reference clock on Armada 375 SoC > >>> clocksource: armada-370-xp: Use the reference clock on A375 SoC > >>> > >>> .../bindings/timer/marvell,armada-370-xp-timer.txt | 9 +++-- > >>> .../devicetree/bindings/watchdog/marvel.txt | 13 +++++++ > >>> drivers/clocksource/time-armada-370-xp.c | 30=20 > >>> ++++++++++++++++ > >>> drivers/watchdog/orion_wdt.c | 42 > >>> +++++++++++++++++++++- > >>> 4 files changed, 90 insertions(+), 4 deletions(-) > >>> > >> > >> > >>-- > >> Linaro.org =E2=94=82 Open source softwar= e for ARM=20 > >> SoCs > >> > >>Follow Linaro: Facebook | > >> Twitter | > >> Blog > >> >=20 >=20 > --=20 > Linaro.org =E2=94=82 Open source software f= or ARM SoCs >=20 > Follow Linaro: Facebook | > Twitter | > Blog >=20 -- To unsubscribe from this list: send the line "unsubscribe linux-watchdo= g" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html