From: Guenter Roeck <linux@roeck-us.net>
To: "Opensource [Steve Twiss]" <stwiss.opensource@diasemi.com>
Cc: Geert Uytterhoeven <geert+renesas@glider.be>,
Wim Van Sebroeck <wim@iguana.be>,
Wolfram Sang <wsa@the-dreams.de>,
Simon Horman <horms@verge.net.au>,
Magnus Damm <magnus.damm@gmail.com>,
Support Opensource <Support.Opensource@diasemi.com>,
Lee Jones <lee.jones@linaro.org>,
"linux-watchdog@vger.kernel.org" <linux-watchdog@vger.kernel.org>,
"linux-i2c@vger.kernel.org" <linux-i2c@vger.kernel.org>,
"linux-sh@vger.kernel.org" <linux-sh@vger.kernel.org>
Subject: Re: [PATCH 1/4] watchdog: da9063: Add restart handler support
Date: Tue, 9 Dec 2014 08:22:22 -0800 [thread overview]
Message-ID: <20141209162222.GA19663@roeck-us.net> (raw)
In-Reply-To: <6ED8E3B22081A4459DAC7699F3695FB7D0B4C115@SW-EX-MBX02.diasemi.com>
On Tue, Dec 09, 2014 at 12:37:15PM +0000, Opensource [Steve Twiss] wrote:
> On 09 December 2014 11:23 Geert Uytterhoeven wrote:
>
[ ... ]
> > + ret = register_restart_handler(&wdt->restart_handler);
> > + if (ret)
> > + dev_err(wdt->da9063->dev,
> > + "Failed to register restart handler (err = %d)\n", ret);
>
> (I guess this is intentional).. if the restart handler doesn't get registered then
> this problem is just ignored and not counted as a real error.
>
This makes sense, since one doesn't want the watchdog driver to fail
loading just because the restart handler failed to register.
One option might be to make the message dev_warn instead of dev_err,
but that is really a nitpick.
Reviewed-by: Guenter Roeck <linux@roeck-us.net>
Thanks,
Guenter
next prev parent reply other threads:[~2014-12-09 16:22 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-12-09 11:22 [PATCH 0/4] ARM: shmobile: koelsch: Add DA9063 watchdog restart support Geert Uytterhoeven
2014-12-09 11:22 ` [PATCH 1/4] watchdog: da9063: Add restart handler support Geert Uytterhoeven
2014-12-09 12:37 ` Opensource [Steve Twiss]
2014-12-09 16:22 ` Guenter Roeck [this message]
2014-12-09 11:22 ` [PATCH 2/4] DT: i2c: Add devices handled by the da9063 MFD driver Geert Uytterhoeven
2014-12-09 12:40 ` Opensource [Steve Twiss]
2015-01-13 10:15 ` Wolfram Sang
2014-12-09 11:22 ` [PATCH 3/4] ARM: shmobile: koelsch: Add DA9063 PMIC device node for system restart Geert Uytterhoeven
2014-12-21 10:52 ` Simon Horman
2014-12-22 13:21 ` Geert Uytterhoeven
2014-12-09 11:22 ` [PATCH 4/4] ARM: shmobile: Enable DA9063 watchdog in multiplatform defconfig Geert Uytterhoeven
2014-12-10 0:33 ` [PATCH 0/4] ARM: shmobile: koelsch: Add DA9063 watchdog restart support Simon Horman
2014-12-10 10:06 ` Geert Uytterhoeven
2014-12-11 1:04 ` Simon Horman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20141209162222.GA19663@roeck-us.net \
--to=linux@roeck-us.net \
--cc=Support.Opensource@diasemi.com \
--cc=geert+renesas@glider.be \
--cc=horms@verge.net.au \
--cc=lee.jones@linaro.org \
--cc=linux-i2c@vger.kernel.org \
--cc=linux-sh@vger.kernel.org \
--cc=linux-watchdog@vger.kernel.org \
--cc=magnus.damm@gmail.com \
--cc=stwiss.opensource@diasemi.com \
--cc=wim@iguana.be \
--cc=wsa@the-dreams.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox