From mboxrd@z Thu Jan 1 00:00:00 1970 Return-path: Date: Mon, 12 Jan 2015 15:08:36 +0100 From: Alexandre Belloni To: Guenter Roeck Cc: Nicolas Ferre , Boris Brezillon , Jean-Christophe Plagniol-Villard , Daniel Lezcano , Thomas Gleixner , Samuel Ortiz , Lee Jones , Wim Van Sebroeck , linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-watchdog@vger.kernel.org Subject: Re: [PATCH v2 3/8] watchdog: at91rm9200: use the regmap from mfd Message-ID: <20150112140836.GL2447@piout.net> References: <1420797094-9444-1-git-send-email-alexandre.belloni@free-electrons.com> <1420797094-9444-4-git-send-email-alexandre.belloni@free-electrons.com> <54B074B9.2090704@roeck-us.net> <20150110184146.GH2447@piout.net> <54B1CE58.4040407@roeck-us.net> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <54B1CE58.4040407@roeck-us.net> List-ID: On 10/01/2015 at 17:14:00 -0800, Guenter Roeck wrote : > Not sure I understand what my comment has to do with 'parent'. > > The fact that the code checks if it has already been instantiated > suggests that the original author of the driver was concerned about > that case. Since you did not remove that check I have to assume that > this can still happen. If so, the second instantiation attempt will > overwrite regmap_st, since that variable is written prior to checking > for the dual instantiation. > I'll move the regmap_st assignment after the check. But I really believe it will never be probed more than once. -- Alexandre Belloni, Free Electrons Embedded Linux, Kernel and Android engineering http://free-electrons.com