From: Guenter Roeck <linux@roeck-us.net>
To: "Muller, Francois-nicolas" <francois-nicolas.muller@intel.com>
Cc: Darren Hart <dvhart@infradead.org>,
"'platform-driver-x86@vger.kernel.org'"
<platform-driver-x86@vger.kernel.org>,
Rafael Wysocki <rjw@rjwysocki.net>,
Linux ACPI Mailing List <linux-acpi@vger.kernel.org>,
"linux-watchdog@vger.kernel.org" <linux-watchdog@vger.kernel.org>,
Wim Van Sebroeck <wim@iguana.be>
Subject: Re: [PATCH] TCO Watchdog warning interrupt driver creation
Date: Wed, 14 Jan 2015 10:16:57 -0800 [thread overview]
Message-ID: <20150114181657.GB13907@roeck-us.net> (raw)
In-Reply-To: <B9C02DB17496AC4197F41A146D371B9B075CC9FA@hasmsx107.ger.corp.intel.com>
On Wed, Jan 14, 2015 at 04:32:33PM +0000, Muller, Francois-nicolas wrote:
> Thanks for your review, my comments embedded below.
> I'm sending the new version of the patch in the following email.
> François-Nicolas
>
...
> >>
> >> +static const struct acpi_device_id iTCO_wdt_ids[] = {
> >> + {"8086229C", 0},
> >> + {"", 0},
> >> +};
> >> +MODULE_DEVICE_TABLE(acpi, iTCO_wdt_ids);
> >> +
> >
> >Doesn't that result in auto-loading the driver ?
>
> The driver is loaded only when Bios exposes the acpi device and the boot param warn_irq is true.
> Could you clarify ? I don't understand the issue.
>
Unless I am missing something, you are making two changes
in a single patch.
- auto-load driver if acpi device is exposed by bios
- Add interrupt handling support
I suggested to separate those changes into two patches.
Guenter
--
To unsubscribe from this list: send the line "unsubscribe linux-watchdog" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
next prev parent reply other threads:[~2015-01-14 18:17 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <B9C02DB17496AC4197F41A146D371B9B075AF9DE@hasmsx107.ger.corp.intel.com>
2014-12-11 4:04 ` [PATCH] TCO Watchdog warning interrupt driver creation Darren Hart
2014-12-11 14:30 ` Guenter Roeck
2014-12-22 13:18 ` Muller, Francois-nicolas
2014-12-22 15:41 ` Darren Hart
2014-12-22 16:07 ` Muller, Francois-nicolas
2015-01-09 5:09 ` Guenter Roeck
2015-01-14 16:32 ` Muller, Francois-nicolas
2015-01-14 18:16 ` Guenter Roeck [this message]
2015-01-15 13:27 ` Muller, Francois-nicolas
2015-01-15 14:49 ` Guenter Roeck
2015-01-20 14:25 ` Muller, Francois-nicolas
2015-01-14 16:38 ` Muller, Francois-nicolas
2015-01-20 15:00 ` Rafael J. Wysocki
2015-02-12 10:13 ` Muller, Francois-nicolas
2015-03-10 16:14 ` Muller, Francois-nicolas
2015-03-18 23:00 ` Rafael J. Wysocki
2015-03-30 13:45 ` Muller, Francois-nicolas
2015-05-12 1:28 ` Guenter Roeck
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150114181657.GB13907@roeck-us.net \
--to=linux@roeck-us.net \
--cc=dvhart@infradead.org \
--cc=francois-nicolas.muller@intel.com \
--cc=linux-acpi@vger.kernel.org \
--cc=linux-watchdog@vger.kernel.org \
--cc=platform-driver-x86@vger.kernel.org \
--cc=rjw@rjwysocki.net \
--cc=wim@iguana.be \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox