From: Wim Van Sebroeck <wim@iguana.be>
To: Matthias Brugger <matthias.bgg@gmail.com>
Cc: robh+dt@kernel.org, pawel.moll@arm.com, mark.rutland@arm.com,
ijc+devicetree@hellion.org.uk, galak@codeaurora.org,
grant.likely@linaro.org, linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org, linux-watchdog@vger.kernel.org,
heiko@sntech.de, yingjoe.chen@gmail.com, ibanezchen@gmail.com,
greta.zhang@mediatek.com, eddie.huang@mediatek.com,
wens@csie.org, linux@roeck-us.net, joe@perches.com
Subject: Re: [PATCH v5 0/2] ARM: mediatek: Add watchdog driver
Date: Tue, 3 Feb 2015 01:02:02 +0100 [thread overview]
Message-ID: <20150203000201.GA18024@spo001.leaseweb.nl> (raw)
In-Reply-To: <1421152136-5007-1-git-send-email-matthias.bgg@gmail.com>
Hi Matthias,
> Mediatek SoCs have a watchdog driver. This patch set adds driver and DTS
> binding. The driver also implements a restart handler to reboot the SoC.
>
> Changes for v5:
> - add newline in dev_info message
> - add tested-by and reviewed-by
>
> Changes for v4:
> - fix indentation errors
> - delete unused include
> - reorganize while loop to eliminate code duplication
> - eliminate indirection to watchdog_device structure
> - delete unnecessary brackets
>
> Changes for v3:
> - fix based on file name
> - fix style problems
> - fix error return value and warning message
> - delete unnecessary watchdog_set_drvdata
> - delete unused variable
>
> Changes for v2:
> - we don't need to have the watchdog enabled to do a software reset
> - disable dual mode and irq mode when starting the watchdog
> - update commit message to name the SoCs the driver supports
>
>
> Matthias Brugger (2):
> watchdog: Add driver for Mediatek watchdog
> ARM: mediatek: dts: Add bindings for watchdog
>
> .../devicetree/bindings/watchdog/mtk-wdt.txt | 13 ++
> drivers/watchdog/Kconfig | 10 +
> drivers/watchdog/Makefile | 1 +
> drivers/watchdog/mtk_wdt.c | 252 +++++++++++++++++++++
> 4 files changed, 276 insertions(+)
> create mode 100644 Documentation/devicetree/bindings/watchdog/mtk-wdt.txt
> create mode 100644 drivers/watchdog/mtk_wdt.c
>
Both patches have been added to linux-watchdog-next.
I made a small change: I removed the .owner field in the platform_driver struct.
This is now normally set by the core.
Kind regards,
Wim.
prev parent reply other threads:[~2015-02-03 0:02 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-01-13 12:28 [PATCH v5 0/2] ARM: mediatek: Add watchdog driver Matthias Brugger
2015-01-13 12:28 ` [PATCH v5 1/2] watchdog: Add driver for Mediatek watchdog Matthias Brugger
2015-01-13 12:28 ` [PATCH v5 2/2] ARM: mediatek: dts: Add bindings for watchdog Matthias Brugger
2015-01-23 14:20 ` [PATCH v5 0/2] ARM: mediatek: Add watchdog driver Matthias Brugger
2015-01-23 17:01 ` Guenter Roeck
2015-02-03 0:02 ` Wim Van Sebroeck [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150203000201.GA18024@spo001.leaseweb.nl \
--to=wim@iguana.be \
--cc=eddie.huang@mediatek.com \
--cc=galak@codeaurora.org \
--cc=grant.likely@linaro.org \
--cc=greta.zhang@mediatek.com \
--cc=heiko@sntech.de \
--cc=ibanezchen@gmail.com \
--cc=ijc+devicetree@hellion.org.uk \
--cc=joe@perches.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-watchdog@vger.kernel.org \
--cc=linux@roeck-us.net \
--cc=mark.rutland@arm.com \
--cc=matthias.bgg@gmail.com \
--cc=pawel.moll@arm.com \
--cc=robh+dt@kernel.org \
--cc=wens@csie.org \
--cc=yingjoe.chen@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox