From mboxrd@z Thu Jan 1 00:00:00 1970 Return-path: Received: from bh-25.webhostbox.net ([208.91.199.152]:33305 "EHLO bh-25.webhostbox.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752157AbbBWT1d (ORCPT ); Mon, 23 Feb 2015 14:27:33 -0500 Received: from mailnull by bh-25.webhostbox.net with sa-checked (Exim 4.82) (envelope-from ) id 1YPyfD-003ZSS-Hs for linux-watchdog@vger.kernel.org; Mon, 23 Feb 2015 19:27:32 +0000 Date: Mon, 23 Feb 2015 11:27:22 -0800 From: Guenter Roeck To: James Hogan Cc: Wim Van Sebroeck , linux-watchdog@vger.kernel.org, James Hogan , Ezequiel Garcia , Naidu Tellapati , Jude Abraham Subject: Re: [PATCH 2/2] watchdog: imgpdc: Fix default heartbeat Message-ID: <20150223192722.GB26070@roeck-us.net> References: <1424475945-30009-1-git-send-email-james.hogan@imgtec.com> <1424475945-30009-3-git-send-email-james.hogan@imgtec.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1424475945-30009-3-git-send-email-james.hogan@imgtec.com> Sender: linux-watchdog-owner@vger.kernel.org List-Id: linux-watchdog@vger.kernel.org On Fri, Feb 20, 2015 at 11:45:45PM +0000, James Hogan wrote: > The IMG PDC watchdog driver heartbeat module parameter has no default so > it is initialised to zero. This results in the following warning during > probe: > > imgpdc-wdt 2006000.wdt: Initial timeout out of range! setting max timeout > > The module parameter description implies that the default value should > be PDC_WDT_DEF_TIMEOUT, which isn't yet used, so initialise it to that. > > Also tweak the heartbeat module parameter description for consistency. > > Fixes: 93937669e9b5 ("watchdog: ImgTec PDC Watchdog Timer Driver") > Signed-off-by: James Hogan > Cc: Wim Van Sebroeck > Cc: Ezequiel Garcia > Cc: Naidu Tellapati > Cc: Jude Abraham > Cc: linux-watchdog@vger.kernel.org Reviewed-by: Guenter Roeck