Re: [PATCH v3 3/9] watchdog: at91rm9200: use the system timer syscon

Guenter Roeck
2015-03-04T17:49:30Z

On Wed, Mar 04, 2015 at 04:08:15PM +0100, Alexandre Belloni wrote:
> On 04/03/2015 at 06:51:51 -0800, Guenter Roeck wrote :
> > >@@ -267,7 +276,7 @@ static struct platform_driver at91wdt_driver = {
> > > .suspend = at91wdt_suspend,
> > > .resume = at91wdt_resume,
> > > .driver = {
> > >- .name = "at91_wdt",
> > >+ .name = "atmel_st_watchdog",
> >
> > If you change the driver name you also need to change the MODULE_ALIAS
> > a few lines down.
> >
> > But why change it in the first place ? Maybe that was discussed somewhere,
> > but not here where it belongs, and not in patch 0/9 either.
> >
>
> That's because it conflicts with drivers/watchdog/at91sam9_wdt.c
>
You still have to update MODULE_ALIAS (or drop it if it is not needed anymore).

Guenter

> I'm not sure that is relevant anymore as they will only be probed using
> DT now.
>
>
> --
> Alexandre Belloni, Free Electrons
> Embedded Linux, Kernel and Android engineering
> http://free-electrons.com