Re: [PATCH v3 4/9] power: reset: Add AT91RM9200 reset driver

Sebastian Reichel
2015-03-04T17:18:11Z

[-- Attachment #1: Type: text/plain, Size: 599 bytes --]

Hi,

On Wed, Mar 04, 2015 at 03:21:32PM +0100, Alexandre Belloni wrote:
> AT91RM9200 uses the watchdog from the system timer to reset.
> [...]
> + regmap_write(regmap_st, AT91_ST_WDMR,
> + AT91_ST_RSTEN | AT91_ST_EXTEN | 1);
> + regmap_write(regmap_st, AT91_ST_CR, AT91_ST_WDRST);
> +
> + mdelay(2000);

At pity that you have to write into two registers, otherwise you
could have used the syscon-reboot driver.

> [...]
> +module_platform_driver(at91rm9200_reset_driver);

Apart from missing module metadata (MODULE_AUTHOR(),
MODULE_LICENSE(), ...) the driver looks fine to me.

-- Sebastian

[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 819 bytes --]