Linux Watchdog driver development
 help / color / mirror / Atom feed
From: Guenter Roeck <linux@roeck-us.net>
To: Ben Dooks <ben.dooks@codethink.co.uk>
Cc: linux-kernel@lists.codethink.co.uk,
	Boris Brezillon <boris.brezillon@free-electrons.com>,
	Nicolas Ferre <nicolas.ferre@atmel.com>,
	Wim Van Sebroeck <wim@iguana.be>,
	linux-watchdog@vger.kernel.org,
	Andrew Victor <linux@maxim.org.za>,
	Jean-Christophe Plagniol-Villard <plagnioj@jcrosoft.com>
Subject: Re: [PATCH] watchdog: at91sam9: use endian agnostic IO
Date: Thu, 26 Mar 2015 08:29:10 -0700	[thread overview]
Message-ID: <20150326152910.GA1115@roeck-us.net> (raw)
In-Reply-To: <1427380454-2002-1-git-send-email-ben.dooks@codethink.co.uk>

On Thu, Mar 26, 2015 at 02:34:14PM +0000, Ben Dooks wrote:
> Use endian agnostic IO functions for the watchdog driver for when it
> is enabled on ATSAMA5D36 devices running in big endian.
> 
> Signed-off-by: Ben Dooks <ben.dooks@codethink.co.uk>

Acked-by: Guenter Roeck <linux@roeck-us.net>

> ---
> CC: Boris Brezillon <boris.brezillon@free-electrons.com>
> CC: Guenter Roeck <linux@roeck-us.net>
> CC: Nicolas Ferre <nicolas.ferre@atmel.com>
> CC: Wim Van Sebroeck <wim@iguana.be>
> CC: linux-watchdog@vger.kernel.org
> CC: Andrew Victor <linux@maxim.org.za>
> CC: Nicolas Ferre <nicolas.ferre@atmel.com>
> CC: Jean-Christophe Plagniol-Villard <plagnioj@jcrosoft.com>
> ---
>  drivers/watchdog/at91sam9_wdt.c | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/drivers/watchdog/at91sam9_wdt.c b/drivers/watchdog/at91sam9_wdt.c
> index 1443b3c..e4698f7 100644
> --- a/drivers/watchdog/at91sam9_wdt.c
> +++ b/drivers/watchdog/at91sam9_wdt.c
> @@ -40,9 +40,9 @@
>  #define DRV_NAME "AT91SAM9 Watchdog"
>  
>  #define wdt_read(wdt, field) \
> -	__raw_readl((wdt)->base + (field))
> +	readl_relaxed((wdt)->base + (field))
>  #define wdt_write(wtd, field, val) \
> -	__raw_writel((val), (wdt)->base + (field))
> +	writel_relaxed((val), (wdt)->base + (field))
>  
>  /* AT91SAM9 watchdog runs a 12bit counter @ 256Hz,
>   * use this to convert a watchdog
> -- 
> 2.1.4
> 

  reply	other threads:[~2015-03-26 15:29 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-03-26 14:34 [PATCH] watchdog: at91sam9: use endian agnostic IO Ben Dooks
2015-03-26 15:29 ` Guenter Roeck [this message]
2015-03-26 23:59 ` Boris Brezillon

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20150326152910.GA1115@roeck-us.net \
    --to=linux@roeck-us.net \
    --cc=ben.dooks@codethink.co.uk \
    --cc=boris.brezillon@free-electrons.com \
    --cc=linux-kernel@lists.codethink.co.uk \
    --cc=linux-watchdog@vger.kernel.org \
    --cc=linux@maxim.org.za \
    --cc=nicolas.ferre@atmel.com \
    --cc=plagnioj@jcrosoft.com \
    --cc=wim@iguana.be \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox