From: Guenter Roeck <linux@roeck-us.net>
To: "Uwe Kleine-König" <u.kleine-koenig@pengutronix.de>
Cc: Wim Van Sebroeck <wim@iguana.be>,
linux-watchdog@vger.kernel.org, kernel@pengutronix.de
Subject: Re: [PATCH] watchdog: gpio-wdt: ping already at startup for always running devices
Date: Fri, 31 Jul 2015 10:18:44 -0700 [thread overview]
Message-ID: <20150731171844.GA6277@roeck-us.net> (raw)
In-Reply-To: <1438327296-17904-1-git-send-email-u.kleine-koenig@pengutronix.de>
On Fri, Jul 31, 2015 at 09:21:36AM +0200, Uwe Kleine-König wrote:
> During probe for an always-running watchdog a timer is setup to
> constantly ping the watchdog while the device is not open. The gpio to
> ping the watchdog is setup to inactive.
>
> For a watchdog with hw_algo = "toggle" this results in a ping depending
> on the initial state of the gpio, for hw_algo = "level" no ping is
> generated.
>
> Make sure that the first automatic ping is sent immediately and not only
> when the timer expires the first time. This makes the machine survive in
> case more than half of the watchdog timeout is already elapsed. (Which
> is very probable for the chip I'm faced with that has a timeout of one
> second.)
>
> Signed-off-by: Uwe Kleine-König <u.kleine-koenig@pengutronix.de>
Makes sense.
Reviewed-by: Guenter Roeck <linux@roeck-us.net>
prev parent reply other threads:[~2015-07-31 17:18 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-07-31 7:21 [PATCH] watchdog: gpio-wdt: ping already at startup for always running devices Uwe Kleine-König
2015-07-31 17:18 ` Guenter Roeck [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150731171844.GA6277@roeck-us.net \
--to=linux@roeck-us.net \
--cc=kernel@pengutronix.de \
--cc=linux-watchdog@vger.kernel.org \
--cc=u.kleine-koenig@pengutronix.de \
--cc=wim@iguana.be \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox